Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed metrics API group name in audit configuration #53493

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Fixed metrics API group name in audit configuration #53493

merged 1 commit into from
Oct 5, 2017

Conversation

piosz
Copy link
Member

@piosz piosz commented Oct 5, 2017 •
edited by wojtek-t
Loading 

Fix metrics API group name in audit configuration

@piosz piosz added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. labels Oct 5, 2017
@piosz piosz added this to the v1.8 milestone Oct 5, 2017
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 5, 2017
@piosz piosz added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 5, 2017
@piosz
Copy link
Member Author

piosz commented Oct 5, 2017

@gmarek could you please approve?

@crassirostris
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2017
@gmarek
Copy link
Contributor

gmarek commented Oct 5, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, gmarek, piosz

Associated issue requirement bypassed by: gmarek

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@crassirostris
Copy link

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1baa304 into kubernetes:master Oct 5, 2017
@piosz piosz deleted the metrics-group branch October 6, 2017 13:11
@kawych kawych mentioned this pull request Oct 16, 2017
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 16, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 17, 2017
Merge pull request #53987 from kawych/automated-cherry-pick-of-#53493…
0d77e9a 
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53493

Cherry pick of #53493 on release-1.8.

#53493: Fixed metrics API group name in audit configuration

```release-note
Fix metrics API group name in audit configuration
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@crassirostris crassirostris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@piosz @crassirostris @gmarek @k8s-github-robot @k8s-cherrypick-bot @k8s-ci-robot