Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #53793 upstream release 1.7 #53884

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Automated cherry pick of #53793 upstream release 1.7 #53884

merged 1 commit into from
Oct 13, 2017

Conversation

wojtek-t
Copy link
Member

Cherry pick of #53793 on release-1.7.

#53793: Use separate client for leader election in scheduler

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 13, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Oct 13, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2017
@shyamjvs
Copy link
Member

Could you please fix the compilation error?

@wojtek-t wojtek-t force-pushed the automated-cherry-pick-of-#53793-upstream-release-1.7 branch from 864a0f9 to 19ca078 Compare October 13, 2017 11:24
@shyamjvs
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shyamjvs, wojtek-t

Associated issue: 53793

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 13, 2017 •
edited
Loading

@wojtek-t: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 19ca078 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit acc1237 into kubernetes:release-1.7 Oct 13, 2017
aveshagarwal pushed a commit to aveshagarwal/origin that referenced this pull request Oct 13, 2017
UPSTREAM: 53793: User separate client for leader election in scheduler
41104fa 
1.7 PR is kubernetes/kubernetes#53884
aveshagarwal pushed a commit to aveshagarwal/origin that referenced this pull request Oct 18, 2017
UPSTREAM: 53793: User separate client for leader election in scheduler
94eb3b9 
1.7 PR is kubernetes/kubernetes#53884
aveshagarwal pushed a commit to aveshagarwal/origin that referenced this pull request Oct 18, 2017
UPSTREAM: 53793: User separate client for leader election in scheduler
57f9478 
1.7 PR is kubernetes/kubernetes#53884
deads2k pushed a commit to openshift/kubernetes that referenced this pull request Oct 31, 2017
@deads2k
UPSTREAM: 53793: User separate client for leader election in schedule…
41d2340 
…r 1.7 PR is kubernetes#53884

:100644 100644 d43ba8aeef... 46b5efe30f... M	plugin/cmd/kube-scheduler/app/configurator.go
:100644 100644 e987c656df... 74a1458649... M	plugin/cmd/kube-scheduler/app/server.go
@wojtek-t wojtek-t deleted the automated-cherry-pick-of-#53793-upstream-release-1.7 branch February 1, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shyamjvs shyamjvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wojtek-t @shyamjvs @k8s-github-robot @k8s-ci-robot