Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubectl to the stable version #54345

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Update kubectl to the stable version #54345

merged 1 commit into from
Dec 4, 2017

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Oct 22, 2017 •
edited by roberthbailey
Loading

What this PR does / why we need it:
Update kubectl to the stable version 1.8.1
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #54762
Special notes for your reviewer:

Release note:

Update kubectl in the addon-manager to v1.8.4

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2017
@roberthbailey
Copy link
Contributor

Please squash your commits and add a release note.

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 22, 2017
@zouyee
Copy link
Member Author

zouyee commented Oct 22, 2017

@roberthbailey has fixed it, thank you!

@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2017
@zouyee
Copy link
Member Author

zouyee commented Oct 24, 2017

@roberthbailey would you like to approve it? thanks!

@roberthbailey
Copy link
Contributor

I'd like @wojtek-t to take a look first

@wojtek-t
Copy link
Member

I'm fine with that.

/lgtm

@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2017
@zouyee
Copy link
Member Author

zouyee commented Oct 27, 2017

/retest

@zouyee
Copy link
Member Author

zouyee commented Oct 29, 2017

gentle ping @roberthbailey

@roberthbailey
Copy link
Contributor

/lgtm
/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2017
@stewart-yu
Copy link
Contributor

I have a question why not update to v1.8.2 now? @zouyee

@roberthbailey
Copy link
Contributor

Are there any changes that affect kubectl in 1.8.2? I don't see anything pertinent listed in the release notes.

@roberthbailey
Copy link
Contributor

/approve no-issue

@zouyee
Copy link
Member Author

zouyee commented Nov 2, 2017

ping @wojtek-t

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2017
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2017
@zouyee
Copy link
Member Author

zouyee commented Nov 29, 2017 •
edited
Loading

Sorry, I was caught in work and missed the PR.

@cblecker
Copy link
Member

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 29, 2017
@cblecker
Copy link
Member

@roberthbailey @wojtek-t Over to you for milestone/labels to allow this to merge.

roberthbailey
roberthbailey reviewed Nov 29, 2017
View reviewed changes
cluster/addons/addon-manager/CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
### Version 8.1 (Sun October 22 2017 zou nengren @zouyee)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the date here and bump the version from 1.8.1 --> 1.8.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it!

@roberthbailey
Copy link
Contributor

/lgtm
/approve

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, roberthbailey, wojtek-t, zouyee

Associated issue: 54762

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

cblecker commented Dec 3, 2017

@roberthbailey If this should get into 1.9, it needs the milestone added. Are you able to do this?

@wojtek-t wojtek-t added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone labels Dec 3, 2017
@wojtek-t wojtek-t added this to the v1.9 milestone Dec 3, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@cblecker @roberthbailey @wojtek-t @zmerlynn @zouyee

Action required: This pull request requires label changes.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
sig owner: Must specify at least one label prefixed with sig/.

Help

@cblecker
Copy link
Member

cblecker commented Dec 3, 2017

/retest

@zouyee
Copy link
Member Author

zouyee commented Dec 4, 2017

/test pull-kubernetes-e2e-kops-aws

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@zouyee
Copy link
Member Author

zouyee commented Dec 4, 2017

kops-aws error

It appears that the test is looking for cat /proc/net/ip_conntrack, but on 4.9 I have /proc/net/nf_conntrack instead

releated issue #56763

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0d22ddc into kubernetes:master Dec 4, 2017
@x13n
Copy link
Member

x13n commented Dec 4, 2017

Is addon manager version going to be synced with kubectl version from now on?

@zouyee zouyee deleted the kubectl branch December 4, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey left review comments

@mariida mariida mariida approved these changes

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@cblecker cblecker

@zmerlynn zmerlynn

@roberthbailey roberthbailey

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

kubectl need to update