Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of prometheus-to-sd to 0.2.2. #54635

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Bump version of prometheus-to-sd to 0.2.2. #54635

merged 1 commit into from
Oct 27, 2017

Conversation

loburm
Copy link
Contributor

@loburm loburm commented Oct 26, 2017 •
edited
Loading

Bump version of prometheus-to-sd to improve logging, add pod_name and
pod_namespace flags and remove deprecated flags.

Fixes #54583

Reduce log noise produced by prometheus-to-sd, by bumping it to version 0.2.2.

@loburm
Bump version of prometheus-to-sd to 0.2.2.
5b62eb2 
Bump version of prometheus-to-sd to improve logging, add pod_name and
pod_namespace flags and remove deprecated flags.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2017
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 26, 2017
@crassirostris
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2017
@crassirostris
Copy link

Please add Fixes ... in the PR description and link the issue

@loburm loburm mentioned this pull request Oct 27, 2017
Merged
@loburm
Copy link
Contributor Author

loburm commented Oct 27, 2017

Added fixes to PR body.

@crassirostris
Copy link

/cc @DirectXMan12 Could you please approve?

@DirectXMan12
Copy link
Contributor

/approve

assuming the Google folks know what they're doing with the argument changes ;-)

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, DirectXMan12, loburm

Associated issue: 54583

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54635, 54250, 54657, 54696, 54700). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 949ec71 into kubernetes:master Oct 27, 2017
@loburm
Copy link
Contributor Author

loburm commented Oct 30, 2017

/cherrypick-candidate

This was referenced Oct 30, 2017
Merged
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 30, 2017
k8s-github-robot pushed a commit that referenced this pull request Nov 2, 2017
Merge pull request #54784 from loburm/automated-cherry-pick-of-#54635…
8fe2737 
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54635

Cherry pick of #54635 on release-1.8.

#54635: Bump version of prometheus-to-sd to 0.2.2.
k8s-github-robot pushed a commit that referenced this pull request Nov 18, 2017
Merge pull request #54783 from loburm/automated-cherry-pick-of-#54635…
712f5b8 
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #54635

Cherry pick of #54635 on release-1.7.

#54635: Bump version of prometheus-to-sd to 0.2.2.

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crassirostris crassirostris

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@loburm @crassirostris @DirectXMan12 @k8s-github-robot @piosz @k8s-ci-robot