Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spaces from kubectl describe hpa #56331

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Remove spaces from kubectl describe hpa #56331

merged 1 commit into from
Jan 16, 2018

Conversation

shiywang
Copy link
Contributor

@shiywang shiywang commented Nov 24, 2017 •
edited
Loading

Fixes comment left here: #36033 (comment)

@kubernetes/sig-cli-pr-reviews @DirectXMan12

remove spaces from kubectl describe hpa

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2017
@shiywang
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@shiywang
Copy link
Contributor Author

@DirectXMan12 @smarterclayton ptal, thanks

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Nov 27, 2017 •
edited
Loading

Please give a more detailed description in the PR body. Please also update the title to at least mention where we are fixing the spaces (e.g. remove spaces from kubectl describe hpa)

EDIT: ignore the "second of all", I misread.

@DirectXMan12
Copy link
Contributor

/assign @DirectXMan12

@shiywang shiywang changed the title fix spaces around the / Remove spaces from kubectl describe hpa Nov 28, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 28, 2017
@shiywang
Copy link
Contributor Author

@DirectXMan12 thanks, release-note added and tittle changed, PTAL

@dixudx
Copy link
Member

dixudx commented Nov 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2017
@shiywang
Copy link
Contributor Author

ping @smarterclayton for approval

@shiywang
Copy link
Contributor Author

/retest

1 similar comment
@DirectXMan12
Copy link
Contributor

/retest

@shiywang
Copy link
Contributor Author

shiywang commented Jan 5, 2018

/assign @pwittrock

@shiywang shiywang mentioned this pull request Jan 5, 2018
Merged
droot
droot approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@shiywang
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@shiywang
Copy link
Contributor Author

@liggitt mind aprove it ?

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@liggitt
Copy link
Member

liggitt commented Jan 16, 2018 •
edited
Loading

/approve no-issue

@kubernetes kubernetes deleted a comment from k8s-github-robot Jan 16, 2018
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@shiywang
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, droot, liggitt, shiywang

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1dbb419 into kubernetes:master Jan 16, 2018
@shiywang shiywang deleted the fix_indent branch January 16, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@droot droot droot approved these changes

Assignees

@DirectXMan12 DirectXMan12

@smarterclayton smarterclayton

@dixudx dixudx

@pwittrock pwittrock

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.