-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Use the v1.9 branch by default #56599
kubeadm: Use the v1.9 branch by default #56599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@enisoc this PR must be merged right before you cut the release candidate
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jamiehannaford, luxas, xiangpengzhao Associated issue requirement bypassed by: luxas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/hold This should be merged right before the release candidate is cut |
@luxas Can you elaborate on why this can't be merged now? |
@enisoc Sure! Well, technically it can indeed, but the issue is that Makes sense to you? |
ping for Milestone update. |
/test pull-kubernetes-e2e-gce |
[MILESTONENOTIFIER] Milestone Pull Request Current @jamiehannaford @timothysc @xiangpengzhao Note: This pull request is marked as Example update:
Pull Request Labels
|
Let's merge this as we're getting close to releasing v1.9.0 :) /hold cancel |
/retest |
/test pull-kubernetes-unit |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 56599, 56824, 56918, 56967, 56959). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
As per https://github.com/kubernetes/kubeadm/blob/master/docs/release-cycle.md, bump the default Kubernetes version to use in kubeadm right before v1.9.0-rc.1 (or maybe rc.0 ?) is cut.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):ref: #47440 #52085
Special notes for your reviewer:
/cc @luxas @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/kubernetes-release-managers
Release note: