Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note prior to interactive confirm of kubeadm upgrade apply #57116

Closed
wants to merge 1 commit into from

Conversation

jipperinbham
Copy link

What this PR does / why we need it:
informs users when running kubeadm upgrade apply in interactive mode to first copy the existing config files in the event they are wanting to diff the changes between versions

Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#489

Special notes for your reviewer:

Release note:

NONE

some users may want to do a comparison of the changes between versions but not think to copy off the existing config files prior to running the upgrade

addresses kubernetes/kubeadm#489
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jipperinbham
We suggest the following additional approver: luxas

Assign the PR to them by writing /assign @luxas in a comment when ready.

Associated issue: #489

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2017
@dims
Copy link
Member

dims commented Dec 13, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 13, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2017

@jipperinbham: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 73108a3 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jipperinbham!
Thanks for this contribution :)

What is the rationale for adding this information?
This is why we added --dry-run, don't you think that is enough for this purpose?
(Feel free to disagree with me :P)

@errordeveloper
Copy link
Member

@jipperinbham is this because --dry-run doesn't actually create files that you can diff directly? In which case, it still seems a little niche to print to the standard output.

@timothysc timothysc assigned errordeveloper and unassigned luxas Jan 19, 2018
@timothysc timothysc added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 19, 2018
@krousey krousey assigned luxas and unassigned krousey Feb 20, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2018
@jipperinbham
Copy link
Author

much better solution was proposed and implemented, #63930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: backup manifest dir gets wiped after upgrade
8 participants