Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated vagrant kube-up implementation #58118

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Remove the deprecated vagrant kube-up implementation #58118

merged 1 commit into from
Jan 12, 2018

Conversation

roberthbailey
Copy link
Contributor

@roberthbailey roberthbailey commented Jan 11, 2018 •
edited
Loading

xref #49213

Remove deprecated vagrant kube-up.sh.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 11, 2018
@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2018
@mikedanese mikedanese added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2018
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2018
@roberthbailey
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@zouyee
Copy link
Member

zouyee commented Jan 11, 2018

/test pull-kubernetes-cross

@roberthbailey roberthbailey mentioned this pull request Jan 11, 2018
Merged
@roberthbailey
Copy link
Contributor Author

/assign jbeda

for top level approval to delete the Vagrant file

@derekwaynecarr
Copy link
Member

/approve

@derekwaynecarr
Copy link
Member

For reference, this was the first solution I wrote to support running kubernetes outside of google, but since those early days, far better solutions have come forward. Happy to see this go now! It's a sign of community progress.

@jbeda
Copy link
Contributor

jbeda commented Jan 12, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2018
@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jbeda, mikedanese, roberthbailey

Associated issue: #49213

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikedanese
Copy link
Member

/unhold

@mikedanese mikedanese removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d05a96b into kubernetes:master Jan 12, 2018
@roberthbailey roberthbailey deleted the vagrant branch February 15, 2018 08:57
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 21, 2018
@dims dims mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@mikedanese mikedanese

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@roberthbailey @mikedanese @zouyee @derekwaynecarr @jbeda @k8s-ci-robot @k8s-github-robot