-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated vagrant kube-up implementation #58118
Conversation
/lgtm |
0b7c929
to
9c03a1e
Compare
9c03a1e
to
8d44e0b
Compare
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
/test pull-kubernetes-cross |
/assign jbeda for top level approval to delete the Vagrant file |
/approve |
For reference, this was the first solution I wrote to support running kubernetes outside of google, but since those early days, far better solutions have come forward. Happy to see this go now! It's a sign of community progress. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, jbeda, mikedanese, roberthbailey Associated issue: #49213 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/unhold |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
xref #49213