Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI: Add a call to reopen log file for a container #58899

Merged
merged 1 commit into from
Jan 30, 2018
Merged

CRI: Add a call to reopen log file for a container #58899

merged 1 commit into from
Jan 30, 2018

Conversation

yujuhong
Copy link
Contributor

This allows a daemon external to the container runtime to rotate the log
file, and then ask the runtime to reopen the files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58823

Release note:

CRI: Add a call to reopen log file for a container.

@yujuhong yujuhong self-assigned this Jan 27, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2018
@yujuhong
Copy link
Contributor Author

/cc @dchen1107 @mrunalp @feiskyer @resouer @portante

@k8s-ci-robot
Copy link
Contributor

@yujuhong: GitHub didn't allow me to request PR reviews from the following users: portante.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dchen1107 @mrunalp @feiskyer @resouer @portante

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yujuhong yujuhong assigned mrunalp, Random-Liu and dchen1107 and unassigned yujuhong Jan 27, 2018
@mrunalp
Copy link
Contributor

mrunalp commented Jan 27, 2018

👍

resouer
resouer reviewed Jan 27, 2018
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from KataContainers view, thanks!

feiskyer
feiskyer reviewed Jan 29, 2018
View reviewed changes
pkg/kubelet/apis/cri/v1alpha1/runtime/api.proto Outdated
@@ -1153,3 +1157,11 @@ message MemoryUsage {
// The amount of working set memory in bytes.
UInt64Value working_set_bytes = 2;
}

message ReopenContainerLogRequest {
// ID of the container for which to retrieve status.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: s/to retrieve status/to reopen container log file/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Random-Liu
Copy link
Member

/test pull-kubernetes-unit
/test pull-kubernetes-bazel-test

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@yujuhong
CRI: Add a call to reopen log file for a container
57d8b64 
This allows a daemon external to the container runtime to rotate the log
file, and then ask the runtime to reopen the files.
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2018
@yujuhong
Copy link
Contributor Author

Fixed the testing fixtures in the commit. Reapplying lgtm.

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2018
@mrunalp
Copy link
Contributor

mrunalp commented Jan 29, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 58899, 58980). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7446f49 into kubernetes:master Jan 30, 2018
@yujuhong yujuhong deleted the reopen-logs branch January 31, 2018 01:12
@StevenYCChou StevenYCChou mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer left review comments

@feiskyer feiskyer feiskyer left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@Random-Liu Random-Liu

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRI: Implement container log rotation
9 participants
@yujuhong @k8s-ci-robot @mrunalp @Random-Liu @fejta-bot @k8s-github-robot @feiskyer @resouer @dchen1107