-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRI: Add a call to reopen log file for a container #58899
Conversation
@yujuhong: GitHub didn't allow me to request PR reviews from the following users: portante. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from KataContainers view, thanks!
@@ -1153,3 +1157,11 @@ message MemoryUsage { | |||
// The amount of working set memory in bytes. | |||
UInt64Value working_set_bytes = 2; | |||
} | |||
|
|||
message ReopenContainerLogRequest { | |||
// ID of the container for which to retrieve status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: s/to retrieve status/to reopen container log file/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/test pull-kubernetes-unit /lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
This allows a daemon external to the container runtime to rotate the log file, and then ask the runtime to reopen the files.
Fixed the testing fixtures in the commit. Reapplying lgtm. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, Random-Liu, yujuhong The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 58899, 58980). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This allows a daemon external to the container runtime to rotate the log
file, and then ask the runtime to reopen the files.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #58823
Release note: