Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in healthchecking etcds leading to crashes #60069

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Fix race in healthchecking etcds leading to crashes #60069

merged 1 commit into from
Feb 20, 2018

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Feb 20, 2018 •
edited
Loading

Fix #59338

Fix race causing apiserver crashes during etcd healthchecking

@wojtek-t wojtek-t added this to the v1.10 milestone Feb 20, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2018
@wojtek-t wojtek-t mentioned this pull request Feb 20, 2018
Closed
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 20, 2018
@mborsz
Copy link
Member

mborsz commented Feb 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@wojtek-t
Copy link
Member Author

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit aa02c0f into kubernetes:master Feb 20, 2018
@wojtek-t wojtek-t mentioned this pull request Feb 20, 2018
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 20, 2018
@wojtek-t wojtek-t mentioned this pull request Feb 20, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Feb 23, 2018
Merge pull request #60077 from wojtek-t/automated-cherry-pick-of-#600…
7f5bf11 
…69-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #60069 upstream release 1.9 

Cherry pick of #60069 on release-1.9.

#60069 : Fix race in healthchecking etcds leading to crashes
k8s-github-robot pushed a commit that referenced this pull request Feb 24, 2018
Merge pull request #60078 from wojtek-t/automated-cherry-pick-of-#600…
c44938c 
…69-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #60069 upstream release 1.8 

Cherry pick of #60069 on release-1.8.

#60069 : Fix race in healthchecking etcds leading to crashes
@wojtek-t wojtek-t deleted the fix_components_statuses_crash branch May 17, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@mborsz mborsz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @mborsz @k8s-ci-robot @k8s-github-robot