-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cadvisor to v0.29.1 #60867
Update cadvisor to v0.29.1 #60867
Conversation
/lgtm |
/priority critical-urgent |
/cc @thockin for approval of the Godep change. Thanks! |
cc @cblecker |
It is worth noting that this only affects the containerd integration, so it is very low risk for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm cancel
/hold
Removing status/approved-for-milestone
until the release team reviews. We have to be careful during code freeze.
@Random-Liu: Can you please review the comments below, as well as explain what is the risk to containerd installs if this doesn't make the release? This doesn't appear to be a very risky change, but we need to understand the pros/cons
Godeps/Godeps.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"ImportPath": "k8s.io/kubernetes", | |||
"GoVersion": "go1.9", | |||
"GoVersion": "go1.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot that I switched to golang 1.10. Will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Godeps/Godeps.json
Outdated
@@ -462,47 +462,47 @@ | |||
}, | |||
{ | |||
"ImportPath": "github.com/containerd/containerd/api/services/containers/v1", | |||
"Comment": "v1.0.0-beta.2-159-g27d450a0", | |||
"Comment": "v1.0.0-beta.2-159-g27d450a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upgrade your git version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Yes, I'd love to know more risk context here. Thanks! |
Why we need this change? If this doesn't make the release, users will sometimes see partial container monitoring stats for Kubernetes+containerd integration, because of the race condition described in google/cadvisor#1894 (comment).
What is the risk?
@cblecker @jdumars Given so, I think this change is a low risky change which fixes a bug for users of Kubernetes+containerd. :) Thanks for asking for the risk context! |
4fc9d07
to
3601590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the information, @Random-Liu!
From a bumping godep perspective, this lgtm. From the side of inclusion in the 1.10 release, based on the information provided, I think this is a low-risk bug fix. I can't speak authoritatively for this area, however. If sig-node agrees, then I'd support inclusion in 1.10.
/approve
/hold cancel |
I'm adding approved for milestone but someone else needs to LGTM this. |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process @Random-Liu @cblecker @dashpole Pull Request Labels
|
@jdumars from sig-node? it does LGTM 👍 to me |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, dashpole, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice work everyone! |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Update cadvisor to v0.29.1 to include a bug fix for containerd integration. google/cadvisor#1894
Release note: