Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure -o yaml populates kind/apiVersion #61808

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Ensure -o yaml populates kind/apiVersion #61808

merged 1 commit into from
Mar 28, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 28, 2018 •
edited

Fixes #61780

kubectl: fixes issue with `-o yaml` and `-o json` omitting kind and apiVersion when used with `--dry-run`

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 28, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2018
@liggitt liggitt added cherrypick-candidate do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2018
@liggitt liggitt added this to the v1.10 milestone Mar 28, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 28, 2018

cc @kubernetes/sig-cli-bugs

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. labels Mar 28, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 28, 2018

/status approved-for-milestone

@liggitt
Copy link
Member Author

liggitt commented Mar 28, 2018

/retest

@liggitt
Copy link
Member Author

liggitt commented Mar 28, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 28, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 28, 2018

/assign @deads2k

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@deads2k @liggitt

Pull Request Labels
  • sig/cli: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@deads2k
Copy link
Contributor

deads2k commented Mar 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 28, 2018
This was referenced Mar 28, 2018
Merged
Closed
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 28, 2018 •
edited

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration a174d7a link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61790, 61808, 60339, 61615, 61757). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 831198e into kubernetes:master Mar 28, 2018
k8s-github-robot pushed a commit that referenced this pull request Mar 29, 2018
Merge pull request #61836 from liggitt/automated-cherry-pick-of-#6180…
15c9e66 
…8-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61808: Ensure -o yaml populates kind/apiVersion

Cherry pick of #61808 on release-1.10.

#61808: Ensure -o yaml populates kind/apiVersion
@liggitt liggitt deleted the dry-run-printing branch April 2, 2018 13:28
@nikhita nikhita mentioned this pull request Apr 4, 2018
Closed
@jsenon jsenon mentioned this pull request Apr 5, 2018
Closed
@liggitt liggitt mentioned this pull request Apr 6, 2018
Closed
@fmoctezuma fmoctezuma mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericchiang ericchiang Awaiting requested review from ericchiang

@sttts sttts Awaiting requested review from sttts

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

--dry-run -o yaml doesn't print a valid Kubernetes object
4 participants
@liggitt @k8s-github-robot @deads2k @k8s-ci-robot