Support custom test configurations #61959
Conversation
k8s-ci-robot
added
size/L
|
/assign @bowei |
k8s-ci-robot
added
release-note
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
|
||
| function usage() { | ||
| echo "usage: $0 [-h] [-d] [-r <pattern>] [-o <filename>]" | ||
| echo " -h display this help message" | ||
| echo " -d enable debug logs in tests" | ||
| echo " -r <pattern> regex pattern to match for tests" | ||
| echo " -o <filename> file to write JSON formatted results to" | ||
| echo " -p <id> enable cpu and memory profiles, output written to mem-<id>.out and cpu-<id>.out" |
There was a problem hiding this comment.
seems easier to pass args after -- directly to the test executable so we don't need to redo the options on each layer
There was a problem hiding this comment.
The reason I exposed this is because the current arguments today are interpreted as a mix of golang args and test specific args passed down the code. Wanted to retain the ease of use and management of these details in the runner.
If we moved to direct args, then I feel it would be better to go test -c and then run the binary with the args directly. But I don't feel we need to make that change just yet.
But it did remind me that I have not updated the README for the custom test configuration, did that and pushed the new changes as part of this PR.
satyasm
force-pushed
the
ipam-perf-cloud-mock
branch
from
fb19da8
to
86aa5ae
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, satyasm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 61959, 62037). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: