Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Bump GLBC manifest to v1.1.1 #62751

Merged
merged 1 commit into from
Apr 18, 2018
Merged

GCE: Bump GLBC manifest to v1.1.1 #62751

merged 1 commit into from
Apr 18, 2018

Conversation

nicksardo
Copy link
Contributor

Special notes for your reviewer:
/assign bowei
/cc bowei
/cc rramkumar1

Release note:

GCE: Bump GLBC version to 1.1.1 - fixing an issue of handling multiple certs with identical certificates

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2018
@bowei
Copy link
Member

bowei commented Apr 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@bowei
Copy link
Member

bowei commented Apr 17, 2018

/approve no-issue

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 62568, 62220, 62743, 62751, 62753). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d6e64a9 into kubernetes:master Apr 18, 2018
@nicksardo nicksardo mentioned this pull request Apr 18, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 20, 2018
Merge pull request #62800 from nicksardo/automated-cherry-pick-of-#62…
4203b10 
…751-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62751: Bump GLBC manifest to v1.1.1

Cherry pick of #62751 on release-1.10.

#62751: Bump GLBC manifest to v1.1.1
@cbandy
Copy link
Contributor

cbandy commented Aug 27, 2018

I noticed that the external dependencies section of the Kubernetes 1.11 release notes say:

  • Ingress glbc is unchanged from 1.10: v1.0.0

@bowei
Copy link
Member

bowei commented Aug 27, 2018

@cbandy -- can you send a PR with the doc fix?

@cbandy
Copy link
Contributor

cbandy commented Aug 27, 2018

Sorry, I don't know how the notes are generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksardo @bowei @k8s-ci-robot @k8s-github-robot @cbandy