Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use subtest for table units (pkg/scheduler/algorithm/predicates) #63660

Merged
merged 1 commit into from
Jun 21, 2018
Merged

use subtest for table units (pkg/scheduler/algorithm/predicates) #63660

merged 1 commit into from
Jun 21, 2018

Conversation

xchapter7x
Copy link
Contributor

@xchapter7x xchapter7x commented May 10, 2018 •
edited
Loading

What this PR does / why we need it: Update scheduler's unit table tests to use subtest

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
breaks up PR: #63281
/ref #63267

Release note:

This PR will leverage subtests on the existing table tests for the scheduler units.
Some refactoring of error/status messages and functions to align with new approach.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2018
@xchapter7x xchapter7x changed the title [WIP] use subtest for table units [WIP] use subtest for table units (pkg/scheduler/algorithm/predicates) May 10, 2018
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 10, 2018
@xchapter7x xchapter7x mentioned this pull request May 10, 2018
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 10, 2018
@xchapter7x xchapter7x changed the title [WIP] use subtest for table units (pkg/scheduler/algorithm/predicates) use subtest for table units (pkg/scheduler/algorithm/predicates) May 10, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2018
@xchapter7x xchapter7x mentioned this pull request May 11, 2018
Closed
misterikkit
misterikkit reviewed May 11, 2018
View reviewed changes
pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
}
}

func TestNodeConditionPredicate(t *testing.T) {
tests := []struct {
tests := map[string]struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from original PR: I don't think this should be a map.

pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
node: &v1.Node{ObjectMeta: metav1.ObjectMeta{Name: "node1"}, Status: v1.NodeStatus{Conditions: []v1.NodeCondition{{Type: v1.NodeReady, Status: v1.ConditionTrue}}}},
schedulable: true,
},
// node2 ignored - node not Ready
{
"node2 ignored - node not Ready": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the '-' in these test names could be changed to a '/'

pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
if fits != test.Fits {
t.Errorf("%s: expected %v got %v", test.Name, test.Fits, fits)
}
t.Run(test.Name, func(t *testing.T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase Name for consistency?

@misterikkit
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2018
@xchapter7x xchapter7x force-pushed the pkg-scheduler-algorithm-predicates branch from ce03bbd to 48eebeb Compare May 12, 2018 13:45
@xchapter7x
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@timothysc timothysc removed their request for review May 14, 2018 19:15
@xchapter7x
Copy link
Contributor Author

/assign @bsalamat

@xchapter7x xchapter7x force-pushed the pkg-scheduler-algorithm-predicates branch from 48eebeb to 8b37590 Compare May 28, 2018 13:46
@bsalamat
Copy link
Member

/assign @misterikkit

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2018
@xchapter7x
use subtest for table units
8bbf182 
apply subtest to predicates
@xchapter7x xchapter7x force-pushed the pkg-scheduler-algorithm-predicates branch from 8b37590 to 8bbf182 Compare June 5, 2018 13:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2018
@idealhack
Copy link
Member

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@misterikkit
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018
bsalamat
bsalamat approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks, @xchapter7x!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, misterikkit, xchapter7x

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64285, 63660, 63661, 63662, 64883). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1712073 into kubernetes:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@misterikkit misterikkit misterikkit approved these changes

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@misterikkit misterikkit

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xchapter7x @misterikkit @bsalamat @idealhack @k8s-ci-robot @fejta-bot @k8s-github-robot