Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CoreDNS version and manifest #64258

Merged
merged 1 commit into from
May 29, 2018
Merged

Update the CoreDNS version and manifest #64258

merged 1 commit into from
May 29, 2018

Conversation

rajansandeep
Copy link
Contributor

What this PR does / why we need it:
Bumps CoreDNS to 1.1.3 and updates manifest

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

CoreDNS is now v1.1.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and dixudx May 24, 2018 12:15
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels May 24, 2018
@rajansandeep
Copy link
Contributor Author

/cc @MrHohn
/cc @luxas

@k8s-ci-robot k8s-ci-robot requested review from luxas and MrHohn May 24, 2018 12:15
MrHohn
MrHohn approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018
@rajansandeep
Copy link
Contributor Author

/assign @fabriziopandini
/retest
@luxas Want to make sure this gets in before code slush! Thanks!

luxas
luxas approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Just one small question, but I guess you want all v1.10.x and v1.11.x versions to use 1.1.3

cmd/kubeadm/app/phases/addons/dns/versions.go
// v1.9.0+ uses kube-dns 1.14.10
// v1.9.0+ uses CoreDNS 1.0.6 if feature gate "CoreDNS" is enabled.
// v1.9.0+ uses kube-dns 1.14.10, if feature gate "CoreDNS" is disabled.
// v1.9.0+ uses CoreDNS 1.1.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All kubernetes versions should use 1.1.3 you mean here, right?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2018
@luxas
Copy link
Member

luxas commented May 29, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64258, 63068). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit af45e9c into kubernetes:master May 29, 2018
@fturib fturib mentioned this pull request May 29, 2018
Closed
@rajansandeep rajansandeep mentioned this pull request May 29, 2018
Closed
@ameukam ameukam mentioned this pull request Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

@dixudx dixudx Awaiting requested review from dixudx

Assignees

@fabriziopandini fabriziopandini

@luxas luxas

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rajansandeep @k8s-ci-robot @luxas @fejta-bot @k8s-github-robot @MrHohn @fabriziopandini