Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block volume support to Cinder volume plugin #64879

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Add block volume support to Cinder volume plugin #64879

merged 1 commit into from
Jun 21, 2018

Conversation

bertinatto
Copy link
Member

What this PR does / why we need it:

This PR adds block volume support to Cinder volume plugin.

Release note:

Added block volume support to Cinder volume plugin.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2018
@k8s-ci-robot k8s-ci-robot requested review from jingxu97 and msau42 June 7, 2018 13:56
@wgliang
Copy link
Contributor

wgliang commented Jun 7, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 7, 2018
@bertinatto
Copy link
Member Author

/test pull-kubernetes-node-e2e

@bertinatto
Copy link
Member Author

/assign @jsafrane

@jsafrane
Copy link
Member

jsafrane commented Jun 8, 2018

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 8, 2018
jsafrane
jsafrane reviewed Jun 8, 2018
View reviewed changes
pkg/volume/cinder/cinder_block.go Outdated
if len(vID) <= 1 {
return nil, fmt.Errorf("failed to get volumeID from global path=%s", globalMapPath)
}
if !strings.Contains(vID, "vol-") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that Cinder volume have really vol- prefix in their IDs. OpenStack GUI show me that there is no specific prefix.

pkg/volume/cinder/cinder_block.go Outdated
return nil, fmt.Errorf("failed to get volumeID from global path=%s, invalid volumeID format = %s", globalMapPath, vID)
}
block := v1.PersistentVolumeBlock
awsVolume := &v1.PersistentVolume{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awsVolume in Cinder code?

pkg/volume/cinder/cinder_block.go Outdated
}

// GetPodDeviceMapPath returns pod device map path and volume name
// path: pods/{podUid}/volumeDevices/kubernetes.io~aws
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws?

jsafrane
jsafrane reviewed Jun 8, 2018
View reviewed changes
Copy link
Member

@jsafrane jsafrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, see one nit below.

Please squash your commits, we want code + test + bazel in one commit unless it's really big one.

api/openapi-spec/swagger.json Outdated
@@ -88401,5 +88401,5 @@
{
"BearerToken": []
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this comes from?

@bertinatto
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2018
@bertinatto bertinatto force-pushed the cinder_block branch 3 times, most recently from 6908dd7 to eab2d1e Compare June 8, 2018 13:37
@bertinatto
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2018
@jsafrane
Copy link
Member

jsafrane commented Jun 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65256, 64236, 64919, 64879, 57932). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f9ec17d into kubernetes:master Jun 21, 2018
tengqm added a commit to tengqm/website that referenced this pull request Jun 21, 2018
@tengqm
Cinder now supports raw block volume
bff023c 
XRef: kubernetes/kubernetes#64879
@tengqm tengqm mentioned this pull request Jun 21, 2018
Closed
@bertinatto bertinatto mentioned this pull request Jul 10, 2018
Merged
@bertinatto bertinatto mentioned this pull request Oct 1, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bertinatto @wgliang @jsafrane @k8s-ci-robot @fejta-bot @k8s-github-robot