Add kms-plugin-container.manifest to release manifest tarball. #65035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @mikedanese |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: immutableT, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
status/approved-for-milestone
and removed
needs-ok-to-test
|
Holding until we verify the fix. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
|
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process Pull Request Labels
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
I build a release of this PR using release/push-build.sh and my test cluster (with KMS integration) came-up fine. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 14, 2018
…5035-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #65035 upstream release 1.10 Add kms-plugin-container.sh to release.sh. ```release-note Due to the mismatch between quick release and bazel release need to manually update release.sh to include kms-plugin-container.manifest in release.sh. Otherwise, when KMS integration is requested kube-apiserver fails to come-up. ``` REF #65035
k8s-ci-robot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
cluster/gce/manifests/kms-plugin-container.manifest needs to be included into the manifests' release tarball.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: