added serviceAccountName to field selectors

[jasonrichardsmith]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #66114

Special notes for your reviewer:

NONE

[jasonrichardsmith]

/sig architecture

[dougm]

/ok-to-test

[jasonrichardsmith]

/test pull-kubernetes-e2e-gce

[juanvallejo]

cc @liggitt

[errordeveloper]

This looks good, but I am not an expert in this area. Perhaps @sttts knows more.

[jasonrichardsmith]

/assign @sttts

[sttts]

/cc @kubernetes/api-reviewers

[mikedanese]

This change seems reasonable to me.

[jasonrichardsmith]

Is there anything else I can do to move this along?

[sttts]

@jasonrichardsmith This needs API review. @liggitt any opinion?

[liggitt]

I don't object to the new selector, though the reasoning behind adding particular field selectors is pretty ad-hoc. It's a little weird that you can select pods by serviceAccountName, but not the workload objects that spawned those pods.

[jasonrichardsmith]

It's so you can audit roles to what is actually bound to those roles using the go client sdk. I can say these pods have access to these roles. I could add it deployments but I didn't feel they were bound to a service account the pod is.

…

On Thu, Aug 9, 2018, 5:40 PM Jordan Liggitt ***@***.***> wrote: I don't object to the new selector, though the reasoning behind adding particular field selectors is pretty ad-hoc. It's a little weird that you can select pods by serviceAccountName, but not the workload objects that spawned those pods. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#66115 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMBcsh216seLUrRebm9oCp_bvcojjPUks5uPFgKgaJpZM4VMfZn> .

[liggitt]

I'm ok with adding this. Any dissenting opinions from @kubernetes/api-reviewers or @kubernetes/sig-scalability-api-reviews?

[liggitt]

/lgtm
/hold
holding for comment through 8/13

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonrichardsmith, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/core/OWNERS [liggitt]
• pkg/registry/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/hold cancel
/retest

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.