replace heketi client implementation

[sigma]

What this PR does / why we need it:

This is an alternate solution for #66305

This change makes use of github.com/sigma/heketi branch k8s-standalone, which is a stripped down, k8s-specific version of github.com/heketi/heketi with:

• only useful client-code, which sidesteps the issue of heketi improperly vendoring k8s (which prevents vgo from working, see kubernetes: use Go modules (vgo) instead of godep #65683)
• uses only Apache 2 licensed code (which addresses partially [Umbrella] License Auditing & Remediation sig-release#223)

For details, see
sigma/heketi@d481979

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This is basically forking heketi/heketi, which is annoying in itself and shouldn't be done lightly. On the other hand, remediation upstream doesn't seem to garner much interest (heketi/heketi#1279 and heketi/heketi#1272), and the heketi module is much larger than we'd like it to be here.

Release note:

NONE

[k8s-ci-robot]

Hi @sigma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sigma
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: humblec, sttts

If they are not already assigned, you can assign the PR to them by writing /assign @humblec @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• Godeps/OWNERS
• pkg/volume/glusterfs/OWNERS
• vendor/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sigma]

/cc @nikhita @thockin

[obnoxxx]

@sigma, I don't think we want to have inofficial heketi client code vendored in the kubernetes repo (at least I don't ;-)). Instead I would prefer working with heketi to improve so that it can better fit in here, and you are already doing that.

@humblec FYI

[sigma]

@obnoxxx I agree, my goal here is mostly to demonstrate that a fix is technically trivial. So hopefully an acceptable fix should at least be achievable :)

[neolit123]

/sig storage

[nikhita]

cc @justaugustus

[sigma]

/hold
while we're figuring out a better upstream story
/meow

[k8s-ci-robot]

@sigma:

In response to this:

/hold
while we're figuring out a better upstream story
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[humblec]

@sigma I agree with @obnoxxx . The client library should be vendor-ed from its official repo. I need to go through the other PRs referenced in this repo in detail. But in quick look, the changes should be in official repo and not in personal repo.

[humblec]

/assign @humblec

[k8s-ci-robot]

@sigma: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

we can close this one too right @sigma ?

[sigma]

@dims yeah, let's close it as I don't think there's appetite for a fork :)

/close

[k8s-ci-robot]

@sigma: Closed this PR.

In response to this:

@dims yeah, let's close it as I don't think there's appetite for a fork :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.