-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick: Update defaultbackend to v1.5 #69381
Cherrypick: Update defaultbackend to v1.5 #69381
Conversation
bowei
commented
Oct 3, 2018
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bowei Can you add a link to release notes of the new version, or some other indication of what are the changes? |
@bowei Do we need this in 1.10.10? If so it needs to be lgtm-ed today. |
/hold |
@MaciekPytel Ref kubernetes/ingress-nginx#3125 this is the PR that resulted in tl;dr: placed in > 1.5 there will be no (ps you can find defaultbackend here now) |
/hold cancel @bowei @jonpulsifer This still needs lgtm. It also needs to merge by Thursday to make it into 1.10.12, which will be the last patch release for 1.10. Finally, I'd appreciate if you edit the release note to contain the information on what changed in 1.5 (one sentence summary of @jonpulsifer comment above). |
/lgtm |
@bowei: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/test pull-kubernetes-godeps |