Ensure orphan public IPs deleted #70463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
feiskyer
force-pushed
the
pip-safe-clean
branch
from
09aaeea
to
4702214
Compare
|
/retest |
andyzhangx
reviewed
Oct 31, 2018
| return err | ||
| } | ||
| } | ||
| glog.V(10).Infof("DeletePublicIPWithRetry(%s, %q): end", pipResourceGroup, pipName) // response not read yet... |
There was a problem hiding this comment.
The comment is actually misleading, let me remove it.
| frontendIPConfigUpdated := false | ||
| loadBalancerRuleUpdated := false | ||
|
|
||
| // Check whether there are still frontend IP configurations referring it. |
feiskyer
force-pushed
the
pip-safe-clean
branch
from
4702214
to
9aeb005
Compare
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-integration |
|
@feiskyer - I'm also able to reproduce another edge case: Delete a loadbalancer service then recreate it before the cleanup. The service will still a pending state the front-end IP being not cleaned up. (this is not a blocker for this one though) |
This was referenced Nov 1, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 2, 2018
…63-upstream-release-1.12 Automated cherry pick of #70463: Ensure orphan public IPs deleted
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 5, 2018
…63-upstream-release-1.10 Automated cherry pick of #70463: Ensure orphan public IPs deleted
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 3, 2018
…63-upstream-release-1.11 Automated cherry pick of #70463: Ensure orphan public IPs deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
After kube-controller-manager restarted, it may get stuck in ensure load balancer as it's trying to delete a public IP that's referenced by an orphan frontend configuration which is no longer referenced by any k8s service.
This PR removed referenced frontend IP configurations and load balancer rules before deleting the public IP.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69352
Special notes for your reviewer:
Note: this is a workaround for #69352, it only deletes orphan public IPs when service recreated with the same name. To complete resolve orphaned load balancer issue, service finalizer should be added (probably v1.14).
Does this PR introduce a user-facing change?:
/sig azure
/kind bug
/milestone v1.13
/cc @brendandburns @khenidak @andyzhangx