Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install CRD's in local cluster #72584

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Install CRD's in local cluster #72584

merged 1 commit into from
Jan 19, 2019

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Jan 4, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR installs CSIDriver and CSINodeInfo CRD's in the local cluster.

Which issue(s) this PR fixes:

Fixes #70791

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Install CSINodeInfo and CSIDriver CRDs in the local cluster.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @xing-yang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from fejta and jbeda January 4, 2019 20:21
@xing-yang
Copy link
Contributor Author

@msau42 @saad-ali

@msau42
Copy link
Member

msau42 commented Jan 4, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2019
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-local-e2e

@fejta
Copy link
Contributor

fejta commented Jan 7, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-local-e2e

@fejta
Copy link
Contributor

fejta commented Jan 7, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from fejta January 7, 2019 21:07
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@msau42
Copy link
Member

msau42 commented Jan 8, 2019

/lgtm cancel
@xing-yang the failure looks like it might be an issue caused by the PR:

W0107 23:56:11.022] /go/src/k8s.io/kubernetes/hack/local-up-cluster.sh: line 868: ps: command not found

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/sig storage

@bertinatto
Copy link
Member

/retest

bertinatto
bertinatto reviewed Jan 8, 2019
View reviewed changes
hack/local-up-cluster.sh
echo "No csinodeinfo available."
fi
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative: we could unify this into a create_crd function that takes a YAML file as parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

bertinatto
bertinatto reviewed Jan 8, 2019
View reviewed changes
hack/local-up-cluster.sh
if [[ ${FEATURE_GATES} == *"CSINodeInfo=true"* ]]; then
create_csinodeinfo
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it wouldn't install the CRDs if FEATURE_GATES is set to AllAlpha=true, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to do something like this instead?

if [[ "${FEATURE_GATES:-}" =~ "CSIDriverRegistry=true" || (...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll change it. Thanks!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2019
@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@bertinatto
Copy link
Member

/test pull-kubernetes-local-e2e

@bertinatto
Copy link
Member

Interesting, occasionally pkill won't be found in $PATH:

201 | W0109 09:35:35.834] 2019/01/09 09:35:35 process.go:153: Running: pkill hyperkube
202 | W0109 09:35:35.884] 2019/01/09 09:35:35 process.go:155: Step 'pkill hyperkube' finished in 110.094µs
203 | W0109 09:35:35.884] 2019/01/09 09:35:35 local.go:225: unable to kill hyperkube processes: error starting pkill hyperkube: exec: "pkill": executable file not found in $PATH
204 | W0109 09:35:35.884] 2019/01/09 09:35:35 process.go:153: Running: pkill etcd
205 | W0109 09:35:35.885] 2019/01/09 09:35:35 process.go:155: Step 'pkill etcd' finished in 8.562µs

@xing-yang
Install CRDs in local cluster
3603013 
This PR installs CSIDriver and CSINodeInfo CRDs in the
local cluster.

fixes: kubernetes#70791
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-integration

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@dims
Copy link
Member

dims commented Jan 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2019
@bertinatto
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2019
@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 6ce59dd into kubernetes:master Jan 19, 2019
@xing-yang xing-yang mentioned this pull request Jan 21, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@dims dims

@bertinatto bertinatto

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local-up-cluster.sh: install CSI CRDs
7 participants
@xing-yang @k8s-ci-robot @msau42 @fejta @fejta-bot @bertinatto @dims