-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scheduler): expose SharedInformerFactory to the framework handle #83663
feat(scheduler): expose SharedInformerFactory to the framework handle #83663
Conversation
736a4ac
to
383f0ce
Compare
/assign @ahg-g |
/retest |
4a5a833
to
9cd9168
Compare
Thanks please squash. /approve |
@ahg-g: GitHub didn't allow me to assign the following users: for, volume-related, tests. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9cd9168
to
d7db0e2
Compare
done |
/lgtm |
this seems like a legitimate failure, we should look closely into it. |
/hold |
/approve |
/test pull-kubernetes-integration |
1 similar comment
/test pull-kubernetes-integration |
d7db0e2
to
ee4dec6
Compare
https://testgrid.k8s.io/google-unit#integration-master&include-filter-by-regex=NodePIDPre It was a flaky test which fails since 10-02 (at least) when this PR wasn't opened. Please take another look, the previous approve does not work as expected. |
/approve |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, draveness, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-informers-factory feat(scheduler): expose SharedInformerFactory to the framework handle
/kind feature
/sig scheduling
/priority important-soon
What this PR does / why we need it:
Which issue(s) this PR fixes:
ref: #83523
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: