-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rest client metrics for client TTL and rot. #84382
Conversation
Hi @sambdavidson. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @awly @logicalhan |
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go
Outdated
Show resolved
Hide resolved
/ok-to-test |
staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
3b90799
to
b1ad584
Compare
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics_test.go
Show resolved
Hide resolved
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go
Outdated
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sambdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
just a BUILD file change /lgtm |
@logicalhan @sambdavidson master reopened for 1.18, you can update this with the gauge func we talked about in a follow up |
Oh, it actually looks like the GaugeFunc was ported over already by @RainbowMango #83830 |
Yes. It is applicable to replace Let me try this case and see if |
* Added rest client metrics for client TTL and rot. * Fixed foo bar comment, added nil checks * Moved rotation observation inside of old cert nil check block * Fixed rotation age logic. * fixed BUILD for exec plugin package * fixed null pointer dereference in exec.go * Updated metric name, bucket, used oldest cert.
/sig auth
/sig instrumentation
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds prometheus metrics to the client-go rest transport to report the TTL and rotation cadence of the client TLS certificates. Improves monitoring capabilities into client certificates nearing expiry and/or issues with certificate refreshing.
Does this PR introduce a user-facing change?: