Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add show-hidden-metrics-for-version to kubelet #85282

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Add show-hidden-metrics-for-version to kubelet #85282

merged 1 commit into from
Feb 26, 2020

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Nov 14, 2019 •
edited
Loading

/kind feature
Ref #85270

Does this PR introduce a user-facing change?:

New flag `--show-hidden-metrics-for-version` in kubelet can be used to show all hidden metrics that deprecated in the previous minor release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md

/cc @RainbowMango

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2019
@RainbowMango RainbowMango mentioned this pull request Nov 15, 2019
Closed
5 tasks
mattjmcnaughton
mattjmcnaughton reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unacc

Not sure I have the context to provide the requested review :)

At a high level, this implementation seems to be inline with the plan discussed in the KEP here. Wondering if the instrumentation folks who commented on the KEP should be the ones to give the sign-off?

cc @logicalhan @brancz

@mattjmcnaughton
Copy link
Contributor

/test pull-kubernetes-node-e2e-containerd

Also, please rebase this diff when you get the chance :) thanks!

@brancz
Copy link
Member

brancz commented Nov 16, 2019

Looks good from instrumentation.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2019
@RainbowMango
Copy link
Member

/test pull-kubernetes-node-e2e-containerd

@RainbowMango
Copy link
Member

/hold
We need to solve the issue first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@RainbowMango
Copy link
Member

@serathius
Please rebase and solve the conflicts. :)

/hold cancel
/milestone v1.18
/priority important-soon
/assign @yujuhong @dashpole

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 26, 2019
@dashpole
Copy link
Contributor

You will want to add this to the kubelet component configuration as well:
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/types.go#L74

You can probably follow this change as an example:
89dfd24#diff-5088ffe9a3539b287e74e2ca03c5090c

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2019
@serathius
Copy link
Contributor Author

/retest

@RainbowMango
Copy link
Member

It seems this ready to go now.
@dashpole Can you take a look again.

@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2020
@serathius
Copy link
Contributor Author

/assign @erictune @yujuhong

@serathius
Copy link
Contributor Author

Ping @erictune @yujuhong

@yujuhong
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2020
@lavalamp
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, serathius, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@RainbowMango
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
@RainbowMango
Copy link
Member

/test pull-kubernetes-e2e-gce-100-performance

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@serathius
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6ec3ea8 into kubernetes:master Feb 26, 2020
@serathius serathius mentioned this pull request May 28, 2020
Merged
@serathius serathius deleted the flag-kubelet branch July 11, 2020 12:06
@ehashman ehashman mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@erictune erictune erictune approved these changes

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@dashpole dashpole

@brancz brancz

@erictune erictune

@RainbowMango RainbowMango

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
10 participants
@serathius @mattjmcnaughton @brancz @RainbowMango @dashpole @fejta-bot @yujuhong @lavalamp @k8s-ci-robot @erictune