Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest cadvisor and containerd (v1.3.3) #86975

Merged
merged 23 commits into from
Mar 25, 2020
Merged

Update to latest cadvisor and containerd (v1.3.3) #86975

merged 23 commits into from
Mar 25, 2020

Conversation

dims
Copy link
Member

@dims dims commented Jan 8, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We use containerd 1.3.x in cluster-api / kind already, it's time to move up to newer dependencies.

Need reviews for/from:

sig-windows:

  • github.com/Microsoft/go-winio
  • github.com/Microsoft/hcsshim
  • github.com/konsorten/go-windows-terminal-sequences

sig-node:

  • github.com/containerd/cgroups
  • github.com/containerd/console
  • github.com/containerd/containerd
  • github.com/containerd/ttrpc
  • github.com/godbus/dbus
  • github.com/google/cadvisor
  • github.com/mistifyio/go-zfs
  • github.com/opencontainers/runc
  • github.com/opencontainers/runtime-spec
  • github.com/opencontainers/selinux

sig-apimachinery:

  • github.com/gogo/protobuf
  • github.com/golang/groupcache
  • github.com/google/go-cmp
  • github.com/hashicorp/golang-lru
  • google.golang.org/genproto
  • google.golang.org/grpc

sig-instrumentation:

  • github.com/prometheus/procfs (sig-instrumentation)
  • go.opencensus.io (sig-instrumentation)

Miscellaneous:

  • github.com/onsi/gomega (sig-testing)
  • github.com/vishvananda/netns (sig-network)
  • golang.org/x/xerrors
  • google.golang.org/appengine (sig-auth)
  • github.com/cilium/ebpf
  • k8s.io/utils/mount (sig-storage)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2020
@dims dims force-pushed the update-hcsshim-v0.8.7-and-containerd-v1.3.2 branch from 21112a2 to bc2d4b5 Compare January 9, 2020 02:29
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2020
@dims dims force-pushed the update-hcsshim-v0.8.7-and-containerd-v1.3.2 branch 2 times, most recently from 655d43a to f073c46 Compare January 9, 2020 11:19
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2020
@dims dims mentioned this pull request Jan 9, 2020
Closed
@dims
Copy link
Member Author

dims commented Jan 9, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-kind-ipv6

@dims
Copy link
Member Author

dims commented Jan 9, 2020

/test pull-kubernetes-e2e-kind-ipv6

dims added 11 commits March 25, 2020 12:09
@dims
Updating dependency github.com/opencontainers/runtime-spec to version…
01e553f 
… v1.0.1
@dims
Updating dependency github.com/opencontainers/selinux to version v1.3.3
a1ef1e8
@dims
Updating dependency github.com/prometheus/procfs to version v0.0.5
af1833d
@dims
Updating dependency github.com/vishvananda/netns to version v0.0.0-20…
2dc8963 
…191106174202-0a2b9b5464df
@dims
Updating dependency google.golang.org/genproto to version v0.0.0-2019…
7555985 
…1230161307-f3c370f40bfb
@dims
Updating dependency gopkg.in/check.v1 to version v1.0.0-2019090208050…
9e91a7d 
…2-41f04d3bba15
@dims
Updating dependency golang.org/x/net to version v0.0.0-20200202094626…
75ceb7b 
…-16171245cfb2
@dims
Updating dependency golang.org/x/time to version v0.0.0-2019102400541…
2b8b3b4 
…4-555d28b269f0
@dims
Updating dependency golang.org/x/xerrors to version v0.0.0-2019120419…
d275539 
…0536-9bdfabe68543
@dims
Updating dependency github.com/checkpoint-restore/go-criu to version …
864646a 
…bdb7599cd87b
@dims
Remove pinned module versions that are not actually used
04e0c93
@dims dims force-pushed the update-hcsshim-v0.8.7-and-containerd-v1.3.2 branch from 8fc35e0 to 04e0c93 Compare March 25, 2020 16:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@liggitt
Copy link
Member

liggitt commented Mar 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2020 •
edited
Loading

@dims: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-aks-engine-azure
pull-kubernetes-conformance-kind-ipv6-parallel 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-gce-csi-serial 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-azure-file 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-azure-file
pull-kubernetes-e2e-azure-disk-vmss 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-azure-disk-vmss
pull-kubernetes-e2e-gce-storage-snapshot 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-storage-slow 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-gce-storage-slow
pull-publishing-bot-validate 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-publishing-bot-validate
pull-kubernetes-e2e-azure-disk 0f53a4c252fe11d7b195309485c2e3ed34f6fc04 link /test pull-kubernetes-e2e-azure-disk

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member Author

dims commented Mar 25, 2020

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 4ad3268 into kubernetes:master Mar 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 25, 2020
@mattjmcnaughton mattjmcnaughton mentioned this pull request Mar 25, 2020
Merged
@dims dims mentioned this pull request Mar 26, 2020
Closed
@BenTheElder
Copy link
Member

I don't know why yet but this seemingly broke kind clusters on certain hosts (google's desktop linux distro and docker for mac I think so far).

kubernetes-sigs/kind#1569 (comment)

Not exactly expecting a revert based on that but ... FYI. And interested in any thoughts why this would be the relevant commit. Possibly kubelet unhealthy + api server does not come up ... not sure why yet.

@liggitt
Copy link
Member

liggitt commented May 6, 2020

nothing leaps to mind, though I'd check the kubelet logs for hints first, given it is responsible for running the apiserver static pod and is the component most affected by this commit. Mind opening an issue to track/discuss?

@dims
Copy link
Member Author

dims commented May 7, 2020

fyi, this problem was already fixed in google/cadvisor#2471

@dghubble dghubble mentioned this pull request Jun 5, 2020
Closed
@dghubble
Copy link
Contributor

dghubble commented Jun 5, 2020 •
edited
Loading

On Fedora CoreOS (but not Flatcar), Kubelet can't start static pods beginning here (in v1.19.0-alpha.1, specifically 4274ea2) and present in v1.19.0-beta.1. Filed as #91795, but wanted to provide a 2nd case to show its broader than just kind and google's OS in case that's helpful.

@BenTheElder
Copy link
Member

this is still present in #89859 (comment) as well

thanks for the details!

@dims
Copy link
Member Author

dims commented Jun 5, 2020

thanks @dghubble that's helpful.

@dghubble dghubble mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickLang PatrickLang PatrickLang left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@dashpole dashpole dashpole left review comments

@liggitt liggitt liggitt left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@kazimsarikaya kazimsarikaya kazimsarikaya approved these changes

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@thockin thockin

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.