Eviction: ignore PDBs if pods with DeletionTimestamp #91342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
Hi @michaelgugino. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
michaelgugino
force-pushed
the
evict-deleted-ok
branch
2 times, most recently
from
0ac0b68
to
7343828
Compare
michaelgugino
changed the title
|
/sig apps |
k8s-ci-robot
added
sig/apps
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
added
the
needs-rebase
When using the eviction API, if a pod already has a non-zero DeletionTimestamp, we don't need to check PDBs as it has already been marked for deletion.
michaelgugino
force-pushed
the
evict-deleted-ok
branch
from
7343828
to
dd49915
Compare
k8s-ci-robot
added
size/S
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/retest /assign @liggitt |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, michaelgugino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-typecheck |
|
/test pull-kubernetes-integration |
|
/retest |
hasheddan
added a commit
to hasheddan/kubernetes
that referenced
this pull request
Jul 11, 2020
In kubernetes#91342 attempting to evict a Pod with a DeletionTimestamp caused checking of PDBs to be ignored due to the fact that a Pod scheduled for deletion should not be factored into a disruption budget. However, PDB eviction tests currently will sometimes select a Pod already scheduled for deletion, expecting that attempting to evict it will conflict with the PDB. This updates those tests to make sure a Pod with deletion timestamp is not selected for eviction when it is intended to violate a PDB. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
tnozicka
pushed a commit
to tnozicka/kubernetes
that referenced
this pull request
Jul 28, 2020
…heduled for deletion In kubernetes#91342 attempting to evict a Pod with a DeletionTimestamp caused checking of PDBs to be ignored due to the fact that a Pod scheduled for deletion should not be factored into a disruption budget. However, PDB eviction tests currently will sometimes select a Pod already scheduled for deletion, expecting that attempting to evict it will conflict with the PDB. This updates those tests to make sure a Pod with deletion timestamp is not selected for eviction when it is intended to violate a PDB. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
sharadg
pushed a commit
to sharadg/kubernetes
that referenced
this pull request
Oct 23, 2020
In kubernetes#91342 attempting to evict a Pod with a DeletionTimestamp caused checking of PDBs to be ignored due to the fact that a Pod scheduled for deletion should not be factored into a disruption budget. However, PDB eviction tests currently will sometimes select a Pod already scheduled for deletion, expecting that attempting to evict it will conflict with the PDB. This updates those tests to make sure a Pod with deletion timestamp is not selected for eviction when it is intended to violate a PDB. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When using the eviction API, if a pod already has
a non-zero DeletionTimestamp, we don't need to check
PDBs as it has already been marked for deletion.
Which issue(s) this PR fixes:
Fixes # #91141
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: