Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json-patch to v4.9.0 tagged release #94147

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Update json-patch to v4.9.0 tagged release #94147

merged 1 commit into from
Aug 21, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 20, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates to a tagged version of json-patch. This is a no-op for k8s.io/kubernetes (no code changes), but ensures that consumers of the k8s.io libraries pick up the desired version (the v0.0.0... version would allow a downstream consumer to use v4.6.0 without realizing it and miss the desired fixes).

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims August 20, 2020 21:08
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 20, 2020
@liggitt liggitt added this to the v1.19 milestone Aug 20, 2020
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Aug 20, 2020
This was referenced Aug 20, 2020
Merged
Merged
@liggitt liggitt mentioned this pull request Aug 20, 2020
Merged
@dims
Copy link
Member

dims commented Aug 20, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2020
@dims
Copy link
Member

dims commented Aug 20, 2020

/retest

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 20, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 20, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@liggitt
Copy link
Member Author

liggitt commented Aug 21, 2020 •
edited
Loading

lint caught an unused dep that needed removing from modules.txt; removed and regenerated

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@dims
Copy link
Member

dims commented Aug 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ce3dd04 into kubernetes:master Aug 21, 2020
@liggitt liggitt mentioned this pull request Aug 24, 2020
Merged
@liggitt liggitt deleted the json-patch branch August 25, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @dims @k8s-ci-robot @fejta-bot