Only add docker group for the docker runtime

kubernetes · Jan 11, 2021 · 1663a03 · 1663a03
1 parent b2121ea
commit 1663a03
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/pkg/drivers/ssh/ssh.go b/pkg/drivers/ssh/ssh.go
@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"net"
 	"os"
+	"os/exec"
 	"path"
 	"strconv"
 	"time"
@@ -124,6 +125,12 @@ func (d *Driver) Create() error {
 		}
 	}
 
+	if d.runtime.Name() == "Docker" {
+		if _, err := d.exec.RunCmd(exec.Command("sudo", "usermod", "-aG", "docker", d.GetSSHUsername())); err != nil {
+			return errors.Wrap(err, "usermod")
+		}
+	}
+
 	log.Debugf("IP: %s", d.IPAddress)
 
 	return nil

diff --git a/pkg/minikube/machine/start.go b/pkg/minikube/machine/start.go
@@ -174,12 +174,6 @@ func createHost(api libmachine.API, cfg *config.ClusterConfig, n *config.Node) (
 		return h, errors.Wrap(err, "post-start")
 	}
 
-	if driver.IsSSH(h.Driver.DriverName()) {
-		if _, err := h.RunSSHCommand(fmt.Sprintf("sudo usermod -aG docker %s", h.Driver.GetSSHUsername())); err != nil {
-			return h, errors.Wrap(err, "usermod")
-		}
-	}
-
 	if err := saveHost(api, h, cfg, n); err != nil {
 		return h, err
 	}