Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-machine-driver-kvm2_1.22.0-0_arm64.deb has wrong package architecture #11930

Closed
mgabeler-lee-6rs opened this issue Jul 8, 2021 · 3 comments · Fixed by #11937
Closed
Assignees
Labels
area/build-release kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@mgabeler-lee-6rs
Copy link

Steps to reproduce the issue:

  1. Download docker-machine-driver-kvm2_1.22.0-0_arm64.deb from the v1.22.0 release
  2. Try to install it on an arm64 system, or (my initial case) try to add it to an apt repo that hosts arm64 packages
  3. Errors out because the package internally says that it's aarch64 when it should be arm64

The minikube package correctly has the arm64 architecture.

Full output of minikube logs command:
N/A

Full output of failed command:

Error looking at 'docker-machine-driver-kvm2_1.22.0-0_arm64.deb': 'aarch64' is not one of the valid architectures: 'i386 amd64 armhf arm64 source'
 new Debian package, version 2.0.
 size 4649436 bytes: control archive=423 bytes.
     446 bytes,    12 lines      control
 Package: docker-machine-driver-kvm2
 Version: 1.22.0
 Section: base
 Priority: optional
 Architecture: aarch64
 Depends: libvirt0 (>= 1.3.1)
 Recommends: minikube
 Maintainer: Thomas Strömberg <t+minikube@stromberg.org>
 Description: Machine driver for KVM
  minikube uses Docker Machine to manage the Kubernetes VM so it benefits
  from the driver plugin architecture that Docker Machine uses to provide
  a consistent way to manage various VM providers.
@RA489
Copy link

RA489 commented Jul 8, 2021

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Jul 8, 2021
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 8, 2021

Simple mistake in 0033bf7, using the wrong architecture for the deb packages:

 out/docker-machine-driver-kvm2_$(DEB_VERSION).deb: out/docker-machine-driver-kvm2_$(DEB_VERSION)-0_amd64.deb
        cp $< $@
 
+out/docker-machine-driver-kvm2_$(DEB_VERSION)-$(DEB_REVISION)_amd64.deb: out/docker-machine-driver-kvm2_$(DEB_VERSION)-0_x86_64.deb
+       cp $< $@
+
+out/docker-machine-driver-kvm2_$(DEB_VERSION)-$(DEB_REVISION)_arm64.deb: out/docker-machine-driver-kvm2_$(DEB_VERSION)-0_aarch64.deb
+       cp $< $@
+

Should be amd64 and arm64 for .deb, even if it is x86_64 and aarch64 for .rpm.

-out/docker-machine-driver-kvm2-$(RPM_VERSION).rpm: out/docker-machine-driver-kvm2-$(RPM_VERSION)-0.x86_64.deb
+out/docker-machine-driver-kvm2-$(RPM_VERSION).rpm: out/docker-machine-driver-kvm2-$(RPM_VERSION)-0.x86_64.rpm
+       cp $< $@
+
+out/docker-machine-driver-kvm2_$(RPM_VERSION).amd64.rpm: out/docker-machine-driver-kvm2-$(RPM_VERSION)-0.x86_64.rpm
+       cp $< $@
+
+out/docker-machine-driver-kvm2_$(RPM_VERSION).arm64.rpm: out/docker-machine-driver-kvm2-$(RPM_VERSION)-0.aarch64.rpm
       cp $< $@

@mgabeler-lee-6rs : as a workaround, you can download the separate arm64 binary.

@afbjorklund afbjorklund added kind/bug Categorizes issue or PR as related to a bug. area/build-release and removed kind/support Categorizes issue or PR as a support question. labels Jul 8, 2021
@medyagh
Copy link
Member

medyagh commented Jul 8, 2021

Cc: @ilya-zuyev

@ilya-zuyev ilya-zuyev self-assigned this Jul 8, 2021
@spowelljr spowelljr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants