Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kvm2 driver arm64 deb package #11937

Merged
merged 6 commits into from
Jul 16, 2021
Merged

Fix kvm2 driver arm64 deb package #11937

merged 6 commits into from
Jul 16, 2021

Conversation

ilya-zuyev
Copy link
Contributor

@ilya-zuyev ilya-zuyev commented Jul 8, 2021 •
edited
Loading

This PR fixes #11930

  • aarch64 in docker-machine-driver-kvm2/arm64 control file changed to arm64

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 8, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 51.9s    | 50.5s               |
| enable ingress | 32.2s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.3s 32.3s 31.8s 32.9s 31.4s
Times for minikube (PR 11937) ingress: 32.9s 31.9s 31.8s 32.9s 32.3s

Times for minikube (PR 11937) start: 47.9s 50.9s 51.2s 50.6s 51.6s
Times for minikube start: 49.5s 49.2s 56.2s 52.9s 51.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.1s               |
| enable ingress | 52.1s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 23.0s 22.3s 22.5s 22.6s
Times for minikube (PR 11937) start: 22.3s 22.6s 21.7s 21.8s 22.1s

Times for minikube ingress: 32.5s 35.5s 122.0s 35.0s 35.5s
Times for minikube (PR 11937) ingress: 35.0s 33.0s 32.0s 37.0s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 44.3s    | 44.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.1s 44.6s 44.1s 44.5s 44.2s
Times for minikube (PR 11937) start: 45.1s 43.8s 44.2s 45.0s 43.8s

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 50.7s               |
| enable ingress | 32.3s    | 32.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 11937) ingress: 32.8s 31.8s 31.9s 34.3s 32.3s
Times for minikube ingress: 31.7s 32.8s 31.8s 33.8s 31.3s

Times for minikube start: 49.7s 52.5s 48.2s 49.8s 47.8s
Times for minikube (PR 11937) start: 56.6s 51.5s 47.1s 50.0s 48.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.4s               |
| enable ingress | 30.5s    | 33.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 11937) start: 22.1s 21.5s 22.9s 23.0s 22.4s
Times for minikube start: 22.6s 21.5s 22.7s 21.8s 21.9s

Times for minikube ingress: 29.0s 36.0s 26.5s 26.5s 34.5s
Times for minikube (PR 11937) ingress: 35.5s 35.0s 32.0s 35.0s 30.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 44.5s    | 44.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.8s 44.6s 44.1s 43.9s 44.2s
Times for minikube (PR 11937) start: 43.8s 43.9s 44.1s 44.2s 44.3s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 50.5s               |
| enable ingress | 32.4s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 52.7s 47.5s 48.8s 51.7s 50.5s
Times for minikube (PR 11937) start: 49.4s 49.2s 50.1s 50.5s 53.6s

Times for minikube ingress: 32.3s 31.4s 32.9s 32.8s 32.8s
Times for minikube (PR 11937) ingress: 33.3s 32.4s 31.8s 31.4s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.6s               |
| enable ingress | 30.5s    | 33.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 22.0s 22.7s 22.3s 22.5s
Times for minikube (PR 11937) start: 22.4s 23.0s 22.3s 22.5s 22.6s

Times for minikube ingress: 26.5s 28.0s 35.0s 34.5s 28.5s
Times for minikube (PR 11937) ingress: 34.5s 31.5s 36.0s 30.6s 32.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 43.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 44.0s 43.6s 43.8s 43.9s
Times for minikube (PR 11937) start: 44.3s 44.5s 41.9s 43.8s 44.2s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 48.1s    | 47.9s               |
| enable ingress | 35.8s    | 33.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 47.6s 49.1s 47.8s 46.5s
Times for minikube (PR 11937) start: 48.9s 49.3s 48.4s 46.8s 46.0s

Times for minikube ingress: 32.8s 40.3s 33.3s 39.8s 32.8s
Times for minikube (PR 11937) ingress: 31.8s 31.7s 32.8s 40.3s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.1s               |
| enable ingress | 35.8s    | 35.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.9s 21.6s 21.3s 21.9s 22.4s
Times for minikube (PR 11937) start: 21.4s 22.6s 22.4s 21.9s 22.4s

Times for minikube ingress: 35.0s 35.5s 36.0s 36.0s 36.6s
Times for minikube (PR 11937) ingress: 36.0s 31.6s 37.0s 35.5s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 40.5s    | 43.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.7s 43.1s 44.4s 43.9s 43.2s
Times for minikube (PR 11937) start: 40.8s 43.9s 43.9s 43.5s 43.6s

@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 47.5s               |
| enable ingress | 32.0s    | 32.8s               |
+----------------+----------+---------------------+

Times for minikube start: 49.9s 46.6s 50.1s 47.9s 47.9s
Times for minikube (PR 11937) start: 46.9s 47.8s 50.3s 46.4s 46.3s

Times for minikube ingress: 33.3s 31.8s 32.7s 31.3s 30.8s
Times for minikube (PR 11937) ingress: 32.4s 31.7s 32.8s 33.8s 33.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.0s               |
| enable ingress | 29.7s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 21.7s 21.8s 21.5s 22.0s
Times for minikube (PR 11937) start: 21.3s 22.4s 22.1s 21.6s 22.7s

Times for minikube ingress: 27.0s 27.5s 34.5s 32.0s 27.5s
Times for minikube (PR 11937) ingress: 35.5s 34.5s 30.5s 30.5s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11937) |
+----------------+----------+---------------------+
| minikube start | 40.7s    | 43.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 43.9s 43.8s 44.2s 39.9s
Times for minikube (PR 11937) start: 43.6s 44.0s 44.4s 43.9s 42.5s

@ilya-zuyev ilya-zuyev requested a review from sharifelgamal July 13, 2021 20:33
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ilya-zuyev,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jul 15, 2021

@ilya-zuyev add to the PR description for the the PR reviwers and the community to know how does removing this make target fixes it ?

@ilya-zuyev ilya-zuyev merged commit 791e3b5 into kubernetes:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-machine-driver-kvm2_1.22.0-0_arm64.deb has wrong package architecture
5 participants
@ilya-zuyev @minikube-pr-bot @k8s-ci-robot @medyagh @sharifelgamal