Don't allow profile names that conflict with a multi-node name

[daehyeok]

Check profile and node name before add to prevent conflict with
machine name on multinode cluster.

Fixes #10061

[k8s-ci-robot]

Hi @daehyeok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

looks good, I would like to see example of it in the PR description

[medyagh]

can we add integration test for this here ? https://github.com/medyagh/minikube/blob/89a8cdc794098f9ba0550fbb5eeb19bc3dd8774d/test/integration/multinode_test.go#L46

[medyagh]

/ok-to-test

[medyagh]

TestMultiNode/serial/RestartMultiNode fails on both Docker and KVM i wonder if it is related?

[daehyeok]

TestMultiNode/serial/RestartMultiNode fails on both Docker and KVM i wonder if it is related?

Fixed it.

minikube/pkg/minikube/node/node.go

Lines 48 to 50 in fb0658c

	if p.Config.Name == cc.Name {
	continue
	}

[medyagh]

@daehyeok do u mind pulling upstream master on this PR ?

[daehyeok]

@daehyeok do u mind pulling upstream master on this PR ?

rebased with upstream master branch

[sharifelgamal]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daehyeok, medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment