Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to opt-in to get notifications for beta releases #11169

Merged
merged 9 commits into from
Apr 29, 2021

Conversation

spowelljr
Copy link
Member

Closes #10328

Added a new config option that the user can enable to get notified of beta releases.

The user can opt-in with the following command:

minikube config set WantBetaUpdateNotification true

Release script need to be updated to update the releases-beta.json file with the release version.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member Author

Just realized that with the current logic, a older beta will take priority over a newer full release. Will resolve this conflict and add a test for it.

@spowelljr spowelljr changed the title Add opt-in notifications for beta releases WIP: Add opt-in notifications for beta releases Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2021
@spowelljr spowelljr changed the title WIP: Add opt-in notifications for beta releases Add opt-in notifications for beta releases Apr 27, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2021
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets change the get Names to proper go idiomatic and then looks good to me

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 29, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11169) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 47.9s               |
| enable ingress | 39.4s    | 40.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 11169) start: 47.2s 49.0s 48.4s 46.0s 49.0s
Times for minikube start: 51.2s 55.3s 49.5s 49.5s 52.1s

Times for minikube ingress: 43.3s 37.8s 36.8s 41.8s 37.7s
Times for minikube (PR 11169) ingress: 42.9s 35.8s 37.8s 44.3s 41.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11169) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.6s               |
| enable ingress | 32.6s    | 36.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.8s 22.4s 21.7s 21.6s 21.6s
Times for minikube (PR 11169) start: 20.8s 21.2s 21.6s 21.9s 22.2s

Times for minikube ingress: 32.5s 33.0s 30.0s 34.0s 33.5s
Times for minikube (PR 11169) ingress: 37.5s 35.5s 36.0s 38.0s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11169) |
+----------------+----------+---------------------+
| minikube start | 41.8s    | 46.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 43.5s 43.1s 43.5s 47.6s
Times for minikube (PR 11169) start: 46.8s 47.0s 44.0s 46.7s 47.1s

@medyagh medyagh merged commit ac2b98d into kubernetes:master Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@medyagh medyagh changed the title Add opt-in notifications for beta releases Add feature to opt-in to get notifications for beta releases Apr 29, 2021
@spowelljr spowelljr deleted the addBetaNotifications branch June 28, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow Minikube users to config receive notification for BETA and RC
5 participants