Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent kube-proxy trying to change nf_conntrack_max #11419

Merged
merged 2 commits into from
May 17, 2021

Conversation

prezha
Copy link
Contributor

@prezha prezha commented May 15, 2021

fixes #11418

an example of the error is given in the description of issue #11418

as detailed in kubernetes-sigs/kind#2240 (comment) and in kubernetes-sigs/kind#2241, as of kernel 5.12.2, kube-proxy will fail while trying to set nf_conntrack_max parameter

this can be avoided by explicitly telling kube-proxy to leave it as-is - ie, passing maxPerCore parameter with value 0 via kubeadm config template
ref: https://kubernetes.io/docs/reference/config-api/kube-proxy-config.v1alpha1/#kubeproxy-config-k8s-io-v1alpha1-KubeProxyConntrackConfiguration

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2021
@prezha
Copy link
Contributor Author

prezha commented May 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 16, 2021
@k8s-ci-robot
Copy link
Contributor

@prezha: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-minikube-build f425739 link /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11419) |
+----------------+----------+---------------------+
| minikube start | 50.1s    | 49.1s               |
| enable ingress | 34.4s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 47.5s 47.0s 55.2s 53.0s 47.8s
Times for minikube (PR 11419) start: 47.4s 47.4s 46.8s 48.6s 55.2s

Times for minikube ingress: 34.4s 34.2s 34.2s 34.7s 34.3s
Times for minikube (PR 11419) ingress: 34.2s 33.7s 33.8s 33.8s 36.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11419) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.6s               |
| enable ingress | 30.1s    | 30.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.5s 29.0s 31.5s 29.5s 32.0s
Times for minikube (PR 11419) ingress: 30.0s 27.5s 36.5s 30.5s 29.5s

Times for minikube start: 21.1s 22.1s 21.1s 21.8s 21.5s
Times for minikube (PR 11419) start: 21.6s 22.1s 21.9s 20.9s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11419) |
+----------------+----------+---------------------+
| minikube start | 44.8s    | 43.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 46.3s 43.1s 43.6s 46.6s 44.5s
Times for minikube (PR 11419) start: 42.3s 47.0s 43.1s 43.2s 43.2s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@medyagh medyagh merged commit 905b3a6 into kubernetes:master May 17, 2021
xavier-rbz added a commit to xavier-rbz/curiefense that referenced this pull request Jul 8, 2021
Prevents an error that looks very similar to
kubernetes/minikube#11419

Signed-off-by: Xavier <xavier@reblaze.com>
Freakachoo pushed a commit to Freakachoo/curiefense that referenced this pull request Jul 14, 2021
Prevents an error that looks very similar to
kubernetes/minikube#11419

Signed-off-by: Xavier <xavier@reblaze.com>
Signed-off-by: Evgeniy Leybovich <evgeniyl@reblaze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-proxy: CrashLoopBackOff with kernel >=5.12.2
5 participants