Add "resume" as an alias for "unpause"

[briandealwis]

This PR adds an alias for the "unpause" command for "resume". I always make a mistaken running minikube resume and then realize that it's unpause.

An alternative would be to use a SuggestFor: ["resume"].

And yes, I should be using auto-pause.

[k8s-ci-robot]

Hi @briandealwis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[afbjorklund]

We sorta left suspend/resume for the VM, but then again it was never implemented either.

And I think it is called "pause" and "resume" in VBoxManage, so there's confusion anyway.

https://www.virtualbox.org/manual/ch08.html#vboxmanage-controlvm

VBoxManage controlvm pause: Temporarily puts a virtual machine on hold, without permanently changing its state. The VM window is gray, to indicate that the VM is currently paused. This is equivalent to selecting the Pause item in the Machine menu of the GUI.

VBoxManage controlvm resume: Undoes a previous pause command. This is equivalent to selecting the Resume item in the Machine menu of the GUI.

VBoxManage controlvm savestate: Saves the current state of the VM to disk and then stops the VM. This is equivalent to selecting the Close item in the Machine menu of the GUI or clicking the VM window's close button, and then selecting Save the Machine State in the displayed dialog.

Not sure if the Docker VM has a similar feature ? How to best separate processes/machines.

Doesn't seem that way, been requested for HyperKit like 5 years. So I guess it does stop/start.

[briandealwis]

Then maybe the SuggestFor is better so as to keep resume available.

[afbjorklund]

Then maybe the SuggestFor is better so as to keep resume available.

Nah, pause/resume is fine. We can do something else, if we do VM sleep

[afbjorklund]

You need to run make generate-docs, then it should be good to go ?

[medyagh]

thank you for this PR @briandealwis would u please make generate-docs

[briandealwis]

I was just running generate-docs and saw that you'd beaten me to the punch @medyagh :-)

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11431) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 47.1s               |
| enable ingress | 38.1s    | 37.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.2s 45.7s 48.7s 46.1s 45.4s
Times for minikube (PR 11431) start: 47.0s 45.3s 50.0s 46.0s 47.1s

Times for minikube ingress: 42.7s 35.7s 34.7s 42.2s 35.3s
Times for minikube (PR 11431) ingress: 41.2s 36.2s 36.2s 36.7s 35.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11431) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.8s               |
| enable ingress | 34.8s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.5s 37.5s 34.6s 34.5s 35.0s
Times for minikube (PR 11431) ingress: 35.0s 37.0s 34.5s 35.0s 36.5s

Times for minikube start: 22.7s 21.1s 21.6s 20.9s 21.0s
Times for minikube (PR 11431) start: 21.8s 21.6s 22.0s 21.7s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11431) |
+----------------+----------+---------------------+
| minikube start | 41.7s    | 44.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 43.0s 43.2s 43.8s 47.5s
Times for minikube (PR 11431) start: 47.5s 43.0s 46.6s 42.9s 43.4s

[briandealwis]

/retest

[medyagh]

thank you @briandealwis

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briandealwis, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment