-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube start --image-repository will now accept URLs with port #11585
Conversation
…URLs with ports, fixing fix validation logic
Welcome @dmpe! |
Hi @dmpe. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
@afbjorklund can you please ok'it to test - so that test can be run. thanks. |
@RA489 maybe you can also take a look? Thanks |
@medyagh Hi, can you please take a look on this. I would like to get it merged :) Thanks. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmpe, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube (PR 11585) ingress: 33.8s 33.7s 36.8s 33.8s 33.8s Times for minikube start: 51.1s 50.4s 48.0s 47.1s 47.9s docker driver with docker runtime
Times for minikube start: 22.4s 22.0s 22.5s 22.7s 21.2s Times for minikube ingress: 29.0s 28.0s 29.5s 33.0s 36.5s docker driver with containerd runtime
Times for minikube start: 43.5s 44.3s 43.9s 43.4s 49.3s |
kvm2 driver with docker runtime
Times for minikube start: 49.2s 46.5s 47.6s 46.4s 47.3s Times for minikube ingress: 33.7s 42.2s 34.7s 36.8s 34.2s docker driver with docker runtime
Times for minikube start: 22.9s 21.3s 21.2s 22.1s 21.4s Times for minikube ingress: 31.9s 34.9s 38.0s 37.5s 33.5s docker driver with containerd runtime
Times for minikube (PR 11585) start: 47.0s 42.8s 47.5s 42.5s 47.3s |
Hi @medyagh, @RA489 @afbjorklund Thanks for running tests on this. Besides them I have also just run my own testing with sonatype/nexus3 container.
Result:
I.e. it is now working and using nexus3 docker images, instead of going outside. This is also validated by the fact, that nexus3 contains all those docker images. 2 Points:
In order to use minikube with nexus3 ports, you will need to specify scheme, even though I am not sure it is necessary. Certainly
This message is also confusing, because port 6668 is not wdyt? There are some tests which fail, but seem to be unrelated to my PR. The executable, used for testing, was downloaded using
|
@dmpe The tests look fine, we have many flaky tests. I left a comment on this PR, it's not a requirement to address the comment, so I'll leave it up to you to decide. If you don't want to implement the comment lmk and I'll merge this PR now. |
kvm2 driver with docker runtime
Times for minikube ingress: 31.3s 33.9s 34.3s 31.4s 31.5s Times for minikube (PR 11585) start: 49.4s 52.9s 50.4s 53.8s 47.4s docker driver with docker runtime
Times for minikube start: 23.9s 23.2s 22.3s 23.1s 21.8s Times for minikube (PR 11585) ingress: 27.5s 35.5s 31.0s 35.5s 36.0s docker driver with containerd runtime
Times for minikube start: 27.8s 42.9s 43.8s 43.7s 43.3s |
Hi @spowelljr - thank you very much for looking into this and giving me a feedback. I have rebased on latest master, run Thanks again
|
fixes #11579
fixes:
misspellings -> rename variables and functions
--image-repository shall now accept URLs with ports
Notes:
go