Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a download link to use arm64 instead of amd64 #11653

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

dongjoon-hyun
Copy link
Contributor

Currently, the error message is correct, but the download link is still pointing amd64. We need to download arm64 binary.

$ minikube version --short

❌  Exiting due to MK_WRONG_BINARY_M1: You are trying to run amd64 binary on M1 system.
Please use darwin/arm64 binary instead
(Download at https://github.com/kubernetes/minikube/releases/download/v1.21.0/minikube-darwin-amd64.)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @dongjoon-hyun!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dongjoon-hyun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ilya-zuyev
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjoon-hyun, ilya-zuyev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11653) |
+----------------+----------+---------------------+
| minikube start | 47.4s    | 46.4s               |
| enable ingress | 36.1s    | 36.1s               |
+----------------+----------+---------------------+

Times for minikube start: 48.7s 46.9s 46.7s 47.9s 47.1s
Times for minikube (PR 11653) start: 45.6s 46.9s 45.9s 47.7s 45.8s

Times for minikube ingress: 36.7s 37.3s 36.7s 34.2s 35.3s
Times for minikube (PR 11653) ingress: 42.7s 32.8s 34.8s 34.2s 36.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11653) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.7s               |
| enable ingress | 30.2s    | 30.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.8s 21.8s 20.9s 21.4s 21.7s
Times for minikube (PR 11653) start: 22.2s 22.3s 21.8s 21.1s 21.2s

Times for minikube (PR 11653) ingress: 29.0s 28.5s 30.0s 37.5s 29.5s
Times for minikube ingress: 26.0s 30.0s 29.5s 36.5s 29.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11653) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 45.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 30.5s 43.2s 43.0s 43.1s 43.1s
Times for minikube (PR 11653) start: 47.3s 47.3s 43.0s 47.3s 43.1s

@ilya-zuyev ilya-zuyev merged commit b64eac3 into kubernetes:master Jun 15, 2021
@dongjoon-hyun
Copy link
Contributor Author

Thank you, @ilya-zuyev !

@dongjoon-hyun dongjoon-hyun deleted the patch-1 branch June 15, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants