Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change registery_mirror to registery-mirror #11678

Merged
merged 1 commit into from
Jun 21, 2021
Merged

change registery_mirror to registery-mirror #11678

merged 1 commit into from
Jun 21, 2021

Conversation

RA489
Copy link

@RA489 RA489 commented Jun 17, 2021

change registery_mirror to registery-mirror

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RA489
To complete the pull request process, please assign ilya-zuyev after the PR has been reviewed.
You can assign the PR to them by writing /assign @ilya-zuyev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jun 17, 2021

good catch @RA489

@medyagh
Copy link
Member

medyagh commented Jun 17, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 17, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 46.8s               |
| enable ingress | 34.3s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 49.3s 47.2s 49.6s 47.0s 50.0s
Times for minikube (PR 11678) start: 46.9s 46.0s 46.9s 46.5s 47.7s

Times for minikube (PR 11678) ingress: 33.2s 32.8s 33.7s 34.2s 37.2s
Times for minikube ingress: 35.2s 35.3s 33.7s 33.7s 33.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 21.3s               |
| enable ingress | 31.1s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.5s 28.5s 31.0s 33.0s 30.5s
Times for minikube (PR 11678) ingress: 36.5s 32.0s 33.0s 29.5s 29.0s

Times for minikube start: 23.4s 22.3s 21.6s 21.5s 22.1s
Times for minikube (PR 11678) start: 20.9s 21.1s 21.1s 22.1s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 42.0s    | 41.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.7s 43.8s 46.1s 42.8s 45.9s
Times for minikube (PR 11678) start: 29.3s 42.4s 47.3s 42.9s 43.0s

@medyagh
Copy link
Member

medyagh commented Jun 18, 2021

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.9s               |
| enable ingress | 34.2s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube start: 47.6s 47.9s 47.6s 46.9s 48.6s
Times for minikube (PR 11678) start: 47.6s 48.6s 47.7s 48.9s 46.7s

Times for minikube ingress: 33.2s 34.2s 33.2s 36.8s 33.7s
Times for minikube (PR 11678) ingress: 33.8s 34.8s 34.3s 34.3s 35.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.4s               |
| enable ingress | 29.1s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 22.0s 21.8s 22.5s 20.8s
Times for minikube (PR 11678) start: 21.3s 21.8s 21.8s 21.1s 20.8s

Times for minikube ingress: 30.4s 29.0s 30.0s 27.5s 28.5s
Times for minikube (PR 11678) ingress: 32.5s 27.5s 29.5s 36.5s 29.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 41.5s    | 44.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.0s 42.8s 43.2s 42.8s 46.8s
Times for minikube (PR 11678) start: 45.9s 43.4s 47.6s 43.8s 42.0s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests Flake Rate (%)
TestPause/serial/Pause 0.00 (chart)
TestPause/serial/VerifyStatus 0.00 (chart)
TestStartStop/group/no-preload/serial/AddonExistsAfterStop 0.00 (chart)
TestStartStop/group/no-preload/serial/SecondStart 0.00 (chart)
TestStartStop/group/no-preload/serial/UserAppExistsAfterStop 0.00 (chart)
TestStartStop/group/no-preload/serial/VerifyKubernetesImages 0.00 (chart)
TestStartStop/group/no-preload/serial/Pause 2.08 (chart)
TestScheduledStopUnix 6.25 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests Flake Rate (%)
TestPause/serial/Pause 13.46 (chart)
TestPause/serial/VerifyStatus 13.46 (chart)
TestPause/serial/PauseAgain 15.38 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests Flake Rate (%)
TestErrorSpam/setup 100.00 (chart)

@RA489
Copy link
Author

RA489 commented Jun 21, 2021

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 47.4s    | 48.2s               |
| enable ingress | 34.1s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 34.7s 33.8s 33.2s 35.3s 33.7s
Times for minikube (PR 11678) ingress: 33.8s 33.8s 33.7s 34.3s 35.2s

Times for minikube start: 47.8s 47.1s 47.4s 46.8s 48.0s
Times for minikube (PR 11678) start: 52.3s 47.0s 47.3s 47.2s 47.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.5s               |
| enable ingress | 30.3s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.3s 21.3s 21.5s 22.5s 22.9s
Times for minikube (PR 11678) start: 21.4s 20.9s 22.5s 21.0s 21.8s

Times for minikube ingress: 32.0s 33.5s 28.5s 27.5s 30.0s
Times for minikube (PR 11678) ingress: 28.0s 32.0s 28.5s 31.0s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11678) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 45.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.5s 46.8s 43.3s 42.9s 46.2s
Times for minikube (PR 11678) start: 46.5s 42.6s 47.0s 42.9s 46.9s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests Flake Rate (%)
TestPause/serial/Pause 11.43 (chart)
TestPause/serial/VerifyStatus 11.43 (chart)
TestPause/serial/PauseAgain 15.71 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests Flake Rate (%)
TestErrorSpam/setup 100.00 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests Flake Rate (%)
TestAddons/parallel/Olm 2.78 (chart)

@medyagh medyagh merged commit c7c06e8 into kubernetes:master Jun 21, 2021
@ilya-zuyev ilya-zuyev mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr Awaiting requested review from spowelljr

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RA489 @k8s-ci-robot @medyagh @minikube-pr-bot @minikube-bot