Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move daemon cache check before file cache check #11690

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Move daemon cache check before file cache check #11690

merged 1 commit into from
Jun 21, 2021

Conversation

andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Jun 17, 2021 •
edited
Loading

fixes #11689.

Before 
$ minikube start
😄  minikube v1.21.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.7 preload ...
    > preloaded-images-k8s-v11-v1...: 492.20 MiB / 492.20 MiB  100.00% 21.70 Mi
    > gcr.io/k8s-minikube/kicbase...: 359.09 MiB / 359.09 MiB  100.00% 14.04 Mi
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.20.7 on Docker 20.10.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ minikube stop
✋  Stopping node "minikube"  ...
🛑  Powering off "minikube" via SSH ...
🛑  1 nodes stopped.
$ docker image ls
REPOSITORY                    TAG       IMAGE ID       CREATED      SIZE
gcr.io/k8s-minikube/kicbase   v0.0.23   9fce26cb202e   9 days ago   1.09GB
$ minikube delete --purge --all
🔥  Deleting "minikube" in docker ...
🔥  Removing /home/andriydzikh/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.
🔥  Successfully deleted all profiles
💀  Successfully purged minikube directory located at - [/home/andriydzikh/.minikube]
$ minikube start
😄  minikube v1.21.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.7 preload ...
    > preloaded-images-k8s-v11-v1...: 492.20 MiB / 492.20 MiB  100.00% 22.43 Mi
    > gcr.io/k8s-minikube/kicbase...: 359.09 MiB / 359.09 MiB  100.00% 13.83 Mi
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.20.7 on Docker 20.10.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
After 
$ minikube start
😄  minikube v1.21.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.7 preload ...
    > preloaded-images-k8s-v11-v1...: 492.20 MiB / 492.20 MiB  100.00% 21.92 Mi
    > gcr.io/k8s-minikube/kicbase...: 359.09 MiB / 359.09 MiB  100.00% 13.45 Mi
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.20.7 on Docker 20.10.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ minikube stop
✋  Stopping node "minikube"  ...
🛑  Powering off "minikube" via SSH ...
🛑  1 nodes stopped.
$ docker image ls
REPOSITORY                    TAG       IMAGE ID       CREATED      SIZE
gcr.io/k8s-minikube/kicbase   v0.0.23   9fce26cb202e   9 days ago   1.09GB
$ minikube delete --purge --all
🔥  Deleting "minikube" in docker ...
🔥  Removing /home/andriydzikh/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.
🔥  Successfully deleted all profiles
💀  Successfully purged minikube directory located at - [/home/andriydzikh/.minikube]
$ minikube start
😄  minikube v1.21.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.7 preload ...
    > preloaded-images-k8s-v11-v1...: 492.20 MiB / 492.20 MiB  100.00% 22.37 Mi
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.20.7 on Docker 20.10.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

@andriyDev
Move daemon cache check before file cache check so cache doesn't need…
95333ed 
… to be repopulated if daemon is already present.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 17, 2021
@andriyDev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 17, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests Flake Rate (%)
TestScheduledStopUnix 4.88 (chart)

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11690) |
+----------------+----------+---------------------+
| minikube start | 46.7s    | 47.5s               |
| enable ingress | 38.2s    | 40.0s               |
+----------------+----------+---------------------+

Times for minikube start: 46.5s 47.1s 47.1s 46.5s 46.3s
Times for minikube (PR 11690) start: 47.1s 45.7s 47.0s 46.0s 51.8s

Times for minikube ingress: 34.7s 44.8s 35.4s 33.8s 42.2s
Times for minikube (PR 11690) ingress: 36.2s 36.7s 41.7s 42.2s 43.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11690) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.4s               |
| enable ingress | 34.5s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 21.6s 21.2s 21.5s 22.0s
Times for minikube (PR 11690) start: 20.8s 21.6s 21.0s 21.3s 22.3s

Times for minikube ingress: 32.5s 33.5s 35.0s 34.4s 36.9s
Times for minikube (PR 11690) ingress: 34.0s 33.5s 33.5s 34.0s 34.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11690) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 43.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.3s 42.9s 43.2s 47.1s 43.4s
Times for minikube (PR 11690) start: 42.5s 47.1s 43.2s 42.9s 43.8s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests Flake Rate (%)
TestErrorSpam/setup 100.00 (chart)

medyagh
medyagh reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u mind pasting before and after this PR ? maybe with the relevent logs to prove this is making minikube not to re-download the image ?

@andriyDev
Copy link
Contributor Author

@medyagh Done. In the second minikube start in the before, the kicbase is downloaded, but in the after the second minikube does not download the kicbase.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andriyDev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@medyagh medyagh merged commit ab41aa5 into kubernetes:master Jun 21, 2021
@andriyDev andriyDev deleted the fix-redownload-kicbase branch June 25, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daemon cached image ignored if missing file cached image
5 participants
@andriyDev @minikube-bot @minikube-pr-bot @k8s-ci-robot @medyagh