Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix ambassador yaml #12450

Closed
wants to merge 1 commit into from
Closed

WIP: fix ambassador yaml #12450

wants to merge 1 commit into from
+171 −165

Conversation

spowelljr
Copy link
Member

Fixes #12442

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2021
@spowelljr
Copy link
Member Author

Require datawire/ambassador-operator#73 to be fixed first

@spowelljr spowelljr closed this Sep 13, 2021
@markshields-gl
Copy link

markshields-gl commented Sep 21, 2021 •
edited
Loading

Hello, this PR was closed without merging, and I'm trying to get our internal services that uses ambassador working with minikube (over docker desktop kubernetes).

@spowelljr, I see you added a requirement of datawire/ambassador-operator#73 to be fixed first, which it has (merged/closed). Can you re-open/merge this PR?

@spowelljr
Copy link
Member Author

spowelljr commented Sep 21, 2021 •
edited
Loading

Hi @markshields-gl, I don't see any activity on ambassador-operator's side. If they do fix it I'm happy to re-open this PR and merge it.

I know it's not ideal, but if you need the ambassador addon to work you can use v1.22.0 of minikube.
https://github.com/kubernetes/minikube/releases/tag/v1.22.0

@spowelljr spowelljr deleted the ambasAddon branch April 26, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addons: ambassador crd validation failure
3 participants
@spowelljr @k8s-ci-robot @markshields-gl