Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure to delete image pull secrets on gcp auth addon disable #12473

Merged
merged 4 commits into from
Sep 16, 2021
Merged

make sure to delete image pull secrets on gcp auth addon disable #12473

merged 4 commits into from
Sep 16, 2021

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Sep 14, 2021 •
edited
Loading

This is an effort to fix #12472 and should happen regardless.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 14, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 49.8s    | 49.1s               |
| enable ingress | 31.5s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 54.1s 47.8s 49.6s 49.8s 47.6s
Times for minikube (PR 12473) start: 49.5s 50.5s 48.4s 48.0s 49.2s

Times for minikube ingress: 32.3s 31.3s 30.9s 31.4s 31.3s
Times for minikube (PR 12473) ingress: 31.3s 37.3s 38.5s 30.8s 31.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.7s               |
| enable ingress | 29.1s    | 31.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.8s 21.1s 22.7s 22.4s
Times for minikube (PR 12473) start: 21.9s 21.5s 21.7s 21.5s 21.7s

Times for minikube ingress: 25.9s 34.0s 24.4s 34.4s 26.9s
Times for minikube (PR 12473) ingress: 33.6s 32.4s 33.4s 25.9s 29.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 40.9s    | 43.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.0s 43.2s 43.2s 43.7s 43.4s
Times for minikube (PR 12473) start: 42.9s 43.4s 43.2s 43.1s 43.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
KVM_Linux TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/GCPAuth (gopogh) 3.42 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 6.54 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 7.79 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.79 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 8.39 (chart)
Docker_Windows TestAddons/parallel/GCPAuth (gopogh) 10.67 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 19.01 (chart)
Docker_Windows TestScheduledStopWindows (gopogh) 23.24 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 28.57 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 34.13 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 50.00 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 57.94 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 58.73 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 58.87 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 61.11 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 65.08 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 79.37 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 91.27 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 49.2s    | 48.8s               |
| enable ingress | 32.5s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube start: 48.6s 51.2s 48.9s 49.2s 48.3s
Times for minikube (PR 12473) start: 48.8s 47.7s 49.3s 49.3s 49.0s

Times for minikube ingress: 32.8s 33.2s 32.3s 31.9s 32.4s
Times for minikube (PR 12473) ingress: 30.8s 32.8s 31.3s 35.4s 30.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 21.6s               |
| enable ingress | 26.8s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 21.0s 21.1s 21.3s 21.7s
Times for minikube (PR 12473) start: 21.0s 21.6s 20.8s 22.6s 22.2s

Times for minikube ingress: 27.4s 26.0s 27.4s 26.9s 26.4s
Times for minikube (PR 12473) ingress: 26.5s 26.4s 25.4s 27.4s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 40.7s    | 40.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.0s 36.7s 43.5s 37.3s 42.9s
Times for minikube (PR 12473) start: 43.7s 26.2s 43.5s 43.3s 43.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/GCPAuth (gopogh) 0.00 (chart)
KVM_Linux TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 2.00 (chart)
KVM_Linux TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 2.00 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 2.67 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 3.85 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 7.74 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 8.28 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 23.28 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 25.00 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 28.03 (chart)
Docker_Windows TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 28.47 (chart)
KVM_Linux TestAddons/parallel/CSI (gopogh) 32.67 (chart)
Docker_Windows TestAddons/Setup (gopogh) 47.22 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 73.02 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/DNS (gopogh) 79.55 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 79.69 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 83.02 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 83.67 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 91.41 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 48.8s    | 48.5s               |
| enable ingress | 33.3s    | 32.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 12473) start: 48.3s 47.8s 48.3s 49.6s 48.5s
Times for minikube start: 52.6s 47.3s 48.0s 48.4s 47.8s

Times for minikube ingress: 34.3s 32.8s 33.3s 32.8s 33.3s
Times for minikube (PR 12473) ingress: 33.4s 34.3s 31.9s 32.3s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.0s               |
| enable ingress | 30.7s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 21.1s 21.6s 22.0s 22.7s
Times for minikube (PR 12473) start: 22.3s 22.4s 21.9s 21.2s 22.1s

Times for minikube ingress: 27.4s 27.9s 34.4s 28.4s 35.4s
Times for minikube (PR 12473) ingress: 35.4s 27.0s 35.9s 28.4s 34.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 40.7s    | 43.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 12473) start: 41.5s 43.9s 42.8s 43.8s 43.5s
Times for minikube start: 27.6s 43.9s 43.9s 44.5s 43.4s

@sharifelgamal sharifelgamal mentioned this pull request Sep 15, 2021
Closed
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestOffline (gopogh) 0.00 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/NetCatPod (gopogh) 1.54 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 3.73 (chart)
Docker_Linux TestAddons/parallel/HelmTiller (gopogh) 8.75 (chart)
KVM_Linux TestAddons/parallel/HelmTiller (gopogh) 9.03 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 12.16 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 22.69 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 24.84 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 25.00 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 27.16 (chart)
Docker_Linux TestAddons/parallel/CSI (gopogh) 28.12 (chart)
KVM_Linux TestAddons/parallel/CSI (gopogh) 32.90 (chart)
Docker_Windows TestAddons/Setup (gopogh) 46.62 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 58.78 (chart)
Docker_Windows TestPause/serial/VerifyStatus (gopogh) 58.78 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 59.86 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 61.83 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/DNS (gopogh) 79.55 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 80.15 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 91.60 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 49.9s    | 48.8s               |
| enable ingress | 32.1s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.3s 49.5s 51.5s 49.9s 49.2s
Times for minikube (PR 12473) start: 49.0s 50.6s 49.0s 48.2s 47.1s

Times for minikube (PR 12473) ingress: 31.3s 31.3s 31.3s 32.3s 32.3s
Times for minikube ingress: 31.9s 32.8s 32.8s 31.3s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.2s               |
| enable ingress | 26.5s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 22.6s 21.6s 21.8s 21.6s
Times for minikube (PR 12473) start: 21.3s 22.2s 22.5s 23.1s 21.8s

Times for minikube ingress: 27.0s 26.4s 26.0s 26.9s 26.4s
Times for minikube (PR 12473) ingress: 26.5s 26.9s 27.0s 26.4s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12473) |
+----------------+----------+---------------------+
| minikube start | 39.6s    | 42.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 39.1s 44.4s 29.8s 42.7s 42.0s
Times for minikube (PR 12473) start: 43.0s 44.3s 42.9s 36.7s 44.0s

@sharifelgamal sharifelgamal merged commit 8e61a96 into kubernetes:master Sep 16, 2021
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueelvis blueelvis Awaiting requested review from blueelvis

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCP Auth addons appears to cause CSI addon test failures
3 participants
@sharifelgamal @k8s-ci-robot @minikube-pr-bot