-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix starting on Windows with VMware driver on non C:
drive
#12819
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube ingress: 30.8s 32.3s 33.7s 32.3s 31.2s Times for minikube start: 50.1s 47.3s 47.2s 46.5s 46.7s docker driver with docker runtime
Times for minikube start: 23.6s 21.7s 21.2s 21.7s 22.2s Times for minikube ingress: 31.4s 37.4s 27.9s 36.9s 35.4s docker driver with containerd runtime
Times for minikube start: 26.8s 43.8s 47.1s 36.4s 40.5s Times for minikube ingress: 33.4s 32.4s 32.4s 30.4s 33.9s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Fixes #12271
Problem:
When starting minikube on Windows machine with the VMware driver with
MINIKUBE_HOME
set to a nonC:
drive, it fails to download the ISO from the host to the VM. This is because the drive is not prepended to the ISO path on the host so it defaults to theC:
drive.Solution:
This issue of not prepending the ISO path with the drive was solved on machine-drivers/machine with machine-drivers/machine#22, however machine-drivers/docker-machine-driver-vmware was instead using docker/machine so I created a PR (machine-drivers/docker-machine-driver-vmware#47) to use machine-drivers/machine instead. This PR updates the version of machine-drivers/docker-machine-driver-vmware to include the changes mentioned above.