Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cri-o from v1.22.0 to 1.22.1 #13059

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Conversation

klaases
Copy link
Contributor

@klaases klaases commented Dec 1, 2021

Fixes: #12956

Update ISO and KIC to use cri-o v1.22.1

Replaces PR: #12959
Template: #12425

References:
https://github.com/cri-o/cri-o/releases
https://newreleases.io/project/github/cri-o/cri-o/release/v1.22.1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @klaases. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: klaases
To complete the pull request process, please assign afbjorklund after the PR has been reviewed.
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@klaases
Copy link
Contributor Author

klaases commented Dec 1, 2021

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @klaases, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/13059/11043b3/iso_build.txt

@klaases
Copy link
Contributor Author

klaases commented Dec 1, 2021

Added new line after CRI-O sha256 entry.

@klaases
Copy link
Contributor Author

klaases commented Dec 1, 2021

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @klaases, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2021
@klaases
Copy link
Contributor Author

klaases commented Dec 1, 2021

The ISO built successfully on remote. Building locally to verify that the version was updated as expected.

@klaases klaases changed the title update cri-o from v1.22.0 to 1.22.1 #12959 update cri-o from v1.22.0 to 1.22.1 Dec 1, 2021
@medyagh
Copy link
Member

medyagh commented Dec 1, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 0 with minikube: timing cmd: [out/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 63
docker driver with docker runtime
error downloading artifacts: downloading artifacts: exit status 81docker driver with containerd runtime
error downloading artifacts: downloading artifacts: exit status 81

@klaases
Copy link
Contributor Author

klaases commented Dec 1, 2021

Have successfully verified that the new ISO shows the updated version of CRI-O.

$ crio --version
crio version 1.22.1
Version:          1.22.1
GitCommit:        63ca93845d5fe05cdca826367afcb601ece8d7ad
GitTreeState:     dirty
BuildDate:        2021-12-01T19:54:57Z
GoVersion:        go1.17
Compiler:         gc
Platform:         linux/amd64
Linkmode:         dynamic
BuildTags:        exclude_graphdriver_devicemapper, containers_image_ostree_stub, seccomp
SeccompEnabled:   true
AppArmorEnabled:  false

Copy link
Contributor Author

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review, have now tested the ISO locally.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 60.63 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 73.40 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 73.98 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 74.49 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 76.19 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 78.05 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartNoArgs (gopogh) 93.90 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit c789413 into kubernetes:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cri-o to v1.22.1
5 participants