Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bind address option for cmd tunnel #14245

Merged

Conversation

te-simonren
Copy link
Contributor

the PR added an bind-address option for minikube tunnel, so we can choose to one interface to bind with.
that's useful as I described in #14234

minikube tunnel --help will show as follow:

➜  ~ minikube tunnel --help
tunnel creates a route to services deployed with type LoadBalancer and sets their Ingress to their ClusterIP. for a
detailed example see https://minikube.sigs.k8s.io/docs/tasks/loadbalancer

Options:
    --bind-address='':
	set tunnel bind address, empty or `*' indicates that tunnel should be available for all interfaces

    -c, --cleanup=true:
	call with cleanup=true to remove old tunnels

Usage:
  minikube tunnel [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).

fixes #14234

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: te-simonren / name: simonren-tes (3184393)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 30, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @te-simonren!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @te-simonren. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 30, 2022
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make generate-docs to update the documentation with your new flag and then push those changes up, thanks!

cmd/minikube/cmd/tunnel.go Outdated Show resolved Hide resolved
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14245) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 51.3s               |
| enable ingress | 25.4s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 51.7s 51.0s 51.2s 51.1s 49.8s
Times for minikube (PR 14245) start: 50.9s 52.0s 51.2s 50.9s 51.5s

Times for minikube ingress: 25.6s 25.0s 25.0s 26.5s 25.0s
Times for minikube (PR 14245) ingress: 29.1s 25.1s 27.0s 29.0s 26.5s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 4.63 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 4.63 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 4.63 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 4.63 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 4.63 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 4.63 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 4.63 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 6.40 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/Start (gopogh) 9.52 (chart)
Docker_Linux_containerd TestAddons/parallel/Registry (gopogh) 11.63 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 24.32 (chart)
Docker_Linux_containerd TestOffline (gopogh) 25.15 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 26.38 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 29.82 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 30.06 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 30.06 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 30.06 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 30.06 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 37.50 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 41.67 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 5fb961c into kubernetes:master Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, te-simonren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bind address with minikube tunnel command
5 participants