-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONFIG_BPF_SYSCALL=y to aarch64 config #15164
Conversation
Can one of the admins verify this patch? |
/assign @medyagh @eiffel-fl |
@brancz: GitHub didn't allow me to assign the following users: eiffel-fl. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi. Thank you for the rebase! $ ./out/minikube start --driver=qemu --iso-url=$(pwd)minikube-arm64.iso
😄 minikube v1.27.0 on Darwin 12.6 (arm64)
✨ Using the qemu2 (experimental) driver based on user configuration
❗ The default network for QEMU will change from 'user' to 'socket_vmnet' in a future release
❗ You are using the QEMU driver without a dedicated network, which doesn't support `minikube service` & `minikube tunnel` commands.
To try the experimental dedicated network see: https://minikube.sigs.k8s.io/docs/drivers/qemu/#networking
💿 Downloading VM boot image ...
🎉 minikube 1.27.1 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v1.27.1
👍 Starting control plane node minikube in cluster minikube
💡 To disable this notice, run: 'minikube config set WantUpdateNotification false'
🔥 Creating qemu2 VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳 Preparing Kubernetes v1.25.1 on Docker 20.10.18 ...
▪ Generating certificates and keys ...
▪ Booting up control plane ...
▪ Configuring RBAC rules ...
🔎 Verifying Kubernetes components...
▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟 Enabled addons: storage-provisioner, default-storageclass
🏄 Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ ./out/minikube start
_ _
_ _ ( ) ( )
___ ___ (_) ___ (_)| |/') _ _ | |_ __
/' _ ` _ `\| |/' _ `\| || , < ( ) ( )| '_`\ /'__`\
| ( ) ( ) || || ( ) || || |\`\ | (_) || |_) )( ___/
(_) (_) (_)(_)(_) (_)(_)(_) (_)`\___/'(_,__/'`\____)
$ zgrep DEBUG_INFO_BTF /proc/config.gz
CONFIG_DEBUG_INFO_BTF=y
$ ls /sys/kernel/btf/vmlinux
/sys/kernel/btf/vmlinux So, your image can be built in the CI! Best regards. |
That would be awesome! 🥳 |
ok-to-build-iso |
Hi @brancz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
ok-to-build-iso |
Hi @brancz, building a new ISO failed. |
Getting the same error as #14675 (comment) |
Is this bug known? I do not really understand why adding a |
Hey @eiffel-fl, any chance you had a look at this? |
Hi! This is still on my TODO list, I will take a look before the end of the year!
Do you have an ISO with which you can play? Meanwhile, I can craft one for you so you can run eBPF related stuff on |
We've been using the first ISO you shared and it has been working flawlessly for months. |
OK, this is a lesser evil but I do totally agree this change should be upstreamed! |
I compiled again the image with this patch locally and was successful doing it. Sadly, I was not able to trigger this race condition locally, is it possible to reproduce the CI environment to try to reproduce the race condition locally? It would ease finding a proper solution. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
If there is absolutely anything we can do to help this along let us know and we'll happily do it! :) |
ok-to-build-iso |
Hi @brancz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
I'm going to build it again to see if it's flaky |
ok-to-build-iso |
Hi @brancz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
ok-to-build-iso |
Hi @brancz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
Pulled and tested, and it looks good! |
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ok-to-build-iso |
Hi @brancz, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
kvm2 driver with docker runtime
Times for minikube (PR 15164) start: 51.7s 50.8s 52.4s 52.2s 49.3s Times for minikube ingress: 29.3s 29.2s 26.8s 27.2s 27.7s docker driver with docker runtime
Times for minikube start: 24.7s 26.4s 24.8s 22.0s 24.2s Times for minikube ingress: 20.8s 19.8s 20.3s 20.8s 20.8s docker driver with containerd runtime
Times for minikube ingress: 19.3s 31.3s 31.4s 18.3s 31.3s Times for minikube start: 20.6s 20.7s 23.3s 20.4s 23.2s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Amazing! Thank you for the merge! |
This is a rebased version of #14675.
Supersedes #14675.
cc @eiffel-fl