Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geneve as a kernel module in minikube ISO #15665

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

wduncanfraser
Copy link
Contributor

Added geneve as a kernel module, so that kube-ovn can be run on minikube.

Without the geneve kernel module, kube-ovn fails to install/run.

This has been tested with a custom ISO build on x86_64.

Reference: https://github.com/kubeovn/kube-ovn/blob/master/docs/install.md

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wduncanfraser / name: W. Duncan Fraser (cd4bc0d)
  • ✅ login: minikube-bot (2b74b90)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @wduncanfraser!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @wduncanfraser. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 18, 2023
@wduncanfraser
Copy link
Contributor Author

Anything I can do to help move this forward?

@afbjorklund
Copy link
Collaborator

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@minikube-bot
Copy link
Collaborator

Hi @wduncanfraser, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2023
@spowelljr spowelljr removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2023
@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @wduncanfraser, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@wduncanfraser
Copy link
Contributor Author

@spowelljr I pulled https://storage.googleapis.com/minikube-builds/iso/15665/minikube-v1.30.1-1686713055-15665-amd64.iso and confirmed it works as expected, with kube-ovn/geneve functional.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15665) |
+----------------+----------+---------------------+
| minikube start | 53.0s    | 51.2s               |
| enable ingress | 27.6s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube start: 51.9s 52.3s 53.7s 57.0s 50.1s
Times for minikube (PR 15665) start: 50.3s 52.7s 50.6s 50.6s 51.9s

Times for minikube ingress: 27.3s 28.3s 27.8s 27.3s 27.3s
Times for minikube (PR 15665) ingress: 28.7s 27.3s 27.3s 27.3s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15665) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 23.1s               |
| enable ingress | 48.7s    | 48.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.5s 24.4s 21.0s 21.9s 24.4s
Times for minikube (PR 15665) start: 22.5s 23.9s 22.8s 24.3s 21.9s

Times for minikube ingress: 49.3s 48.3s 48.8s 48.8s 48.3s
Times for minikube (PR 15665) ingress: 48.3s 49.3s 49.3s 49.3s 48.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15665) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 22.9s               |
| enable ingress | 34.3s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 22.8s 23.8s 23.1s 22.9s
Times for minikube (PR 15665) start: 23.4s 23.7s 23.0s 23.5s 20.6s

Times for minikube ingress: 30.4s 31.3s 31.3s 47.3s 31.3s
Times for minikube (PR 15665) ingress: 30.3s 32.3s 31.3s 31.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_docker_arm64 TestRunningBinaryUpgrade (gopogh) 2.56 (chart)
Docker_Linux_crio TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 4.46 (chart)
Hyperkit_macOS TestRunningBinaryUpgrade (gopogh) 13.33 (chart)
KVM_Linux TestMultiNode/serial/StartAfterStop (gopogh) 13.38 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh) 47.14 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit e94ff85 into kubernetes:master Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, r0b2g1t, spowelljr, wduncanfraser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wduncanfraser wduncanfraser deleted the add-geneve branch June 14, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants