-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added geneve as a kernel module in minikube ISO #15665
Conversation
Welcome @wduncanfraser! |
Hi @wduncanfraser. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Anything I can do to help move this forward? |
ok-to-build-iso |
Hi @wduncanfraser, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
ok-to-build-iso |
Hi @wduncanfraser, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
@spowelljr I pulled https://storage.googleapis.com/minikube-builds/iso/15665/minikube-v1.30.1-1686713055-15665-amd64.iso and confirmed it works as expected, with kube-ovn/geneve functional. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 51.9s 52.3s 53.7s 57.0s 50.1s Times for minikube ingress: 27.3s 28.3s 27.8s 27.3s 27.3s docker driver with docker runtime
Times for minikube start: 24.5s 24.4s 21.0s 21.9s 24.4s Times for minikube ingress: 49.3s 48.3s 48.8s 48.8s 48.3s docker driver with containerd runtime
Times for minikube start: 23.2s 22.8s 23.8s 23.1s 22.9s Times for minikube ingress: 30.4s 31.3s 31.3s 47.3s 31.3s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, r0b2g1t, spowelljr, wduncanfraser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added geneve as a kernel module, so that kube-ovn can be run on minikube.
Without the geneve kernel module, kube-ovn fails to install/run.
This has been tested with a custom ISO build on x86_64.
Reference: https://github.com/kubeovn/kube-ovn/blob/master/docs/install.md