Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO/Kicbase: Update cri-dockerd from 0.3.0 to 0.3.1 #15752

Merged
merged 7 commits into from
Feb 15, 2023
Merged

ISO/Kicbase: Update cri-dockerd from 0.3.0 to 0.3.1 #15752

merged 7 commits into from
Feb 15, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jan 30, 2023 •
edited
Loading

Used some code from @afbjorklund's #14827

Also updated automation to auto update hash files

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@spowelljr spowelljr mentioned this pull request Jan 31, 2023
Closed
@spowelljr spowelljr marked this pull request as ready for review February 2, 2023 17:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2023
@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new kicbase image failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/15752/1bb8217/kic_image_build.txt

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/15752/1bb8217/iso_build.txt

@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/15752/49b3724/iso_build.txt

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/15752/3006b3e/iso_build.txt

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 15, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15752) |
+----------------+----------+---------------------+
| minikube start | 54.8s    | 53.1s               |
| enable ingress | 26.0s    | 25.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 15752) ingress: 25.2s 27.2s 25.3s 25.3s 25.2s
Times for minikube ingress: 24.2s 28.2s 24.3s 27.2s 26.3s

Times for minikube start: 53.4s 54.6s 56.3s 54.5s 55.5s
Times for minikube (PR 15752) start: 55.7s 50.3s 53.3s 52.1s 54.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15752) |
+----------------+----------+---------------------+
| minikube start | 27.5s    | 27.0s               |
| enable ingress | 21.7s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 29.1s 26.0s 26.7s 28.4s 27.6s
Times for minikube (PR 15752) start: 28.0s 26.9s 27.8s 26.7s 25.7s

Times for minikube ingress: 21.1s 22.1s 21.1s 22.1s 22.1s
Times for minikube (PR 15752) ingress: 22.1s 23.1s 22.1s 23.1s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15752) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.3s               |
| enable ingress | 42.0s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 23.2s 22.8s 22.3s 22.4s
Times for minikube (PR 15752) start: 22.5s 22.3s 22.3s 21.9s 22.5s

Times for minikube ingress: 32.6s 32.6s 32.6s 79.6s 32.6s
Times for minikube (PR 15752) ingress: 32.6s 19.6s 21.7s 33.6s 31.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 1.24 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 1.24 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.76 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

medyagh
medyagh approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 8d12bf3 into kubernetes:master Feb 15, 2023
@spowelljr spowelljr deleted the updateCriDockerd branch February 15, 2023 23:46
This was referenced Feb 16, 2023
Closed
Closed
@spowelljr spowelljr mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @k8s-ci-robot @minikube-bot @minikube-pr-bot @medyagh