Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress pod to logs output #15775

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

spowelljr
Copy link
Member

  • Add ingress pod to logs output
  • Refactor logic to make it easy to add new addons to logs in the future
  • Move existing addon pods to new logic to save checking for pod that may not exist

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2023
@medyagh
Copy link
Member

medyagh commented Feb 8, 2023

merge after tests are passing

@medyagh
Copy link
Member

medyagh commented Feb 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr, YasinAshorian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15775) |
+----------------+----------+---------------------+
| minikube start | 55.0s    | 54.4s               |
| enable ingress | 26.0s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 54.7s 53.6s 54.5s 56.7s 55.3s
Times for minikube (PR 15775) start: 53.9s 56.0s 54.7s 54.0s 53.5s

Times for minikube ingress: 25.2s 24.2s 24.2s 28.7s 27.7s
Times for minikube (PR 15775) ingress: 24.7s 26.7s 28.7s 29.7s 27.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15775) |
+----------------+----------+---------------------+
| minikube start | 27.0s    | 26.7s               |
| enable ingress | 39.2s    | 33.2s               |
+----------------+----------+---------------------+

Times for minikube start: 27.0s 27.1s 27.1s 26.5s 27.0s
Times for minikube (PR 15775) start: 26.7s 27.1s 26.2s 26.7s 27.0s

Times for minikube ingress: 21.6s 21.1s 81.6s 21.6s 50.1s
Times for minikube (PR 15775) ingress: 21.1s 22.1s 81.1s 22.1s 19.6s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15775) |
+-------------------+----------+---------------------+
| minikube start    | 22.4s    | 22.2s               |
| ⚠️  enable ingress | 32.0s    | 38.7s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 22.4s 22.9s 22.1s 21.9s 22.6s
Times for minikube (PR 15775) start: 22.9s 23.0s 21.6s 21.8s 21.4s

Times for minikube ingress: 31.6s 31.6s 31.6s 32.6s 32.6s
Times for minikube (PR 15775) ingress: 79.6s 18.1s 31.6s 31.6s 32.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 10.06 (chart)
Docker_Linux_containerd TestDownloadOnlyKic (gopogh) 45.00 (chart)
Docker_Linux TestDownloadOnlyKic (gopogh) 45.00 (chart)
Hyper-V_Windows TestAddons/parallel/CloudSpanner (gopogh) 53.12 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.04 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 3a9c9a8 into kubernetes:master Feb 10, 2023
@spowelljr spowelljr deleted the addIngressAddonToLogs branch March 16, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants