Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube service list: fix table format & hide URLs #15911

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

spowelljr
Copy link
Member

Fix Table

Before:

|-------------|----------------|--------------|-----|
|  NAMESPACE  |      NAME      | TARGET PORT  | URL |
|-------------|----------------|--------------|-----|
| default     | hello-minikube |         8080 |     |
| default     | kubernetes     | No node port |
| kube-system | kube-dns       | No node port |
|-------------|----------------|--------------|-----|

After:

|-------------|----------------|--------------|-----|
|  NAMESPACE  |      NAME      | TARGET PORT  | URL |
|-------------|----------------|--------------|-----|
| default     | hello-minikube |         8080 |     |
| default     | kubernetes     | No node port |     |
| kube-system | kube-dns       | No node port |     |
|-------------|----------------|--------------|-----|

Improve URL hiding

Before:

URLs were only hid on macOS for users using Docker Desktop

After:

URLS are hidden on macOS, Linux, and Windows for users using Docker Desktop

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Feb 22, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 22, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15911) |
+----------------+----------+---------------------+
| minikube start | 52.4s    | 51.8s               |
| enable ingress | 27.2s    | 25.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 24.2s 28.2s 29.2s 28.6s 25.7s
Times for minikube (PR 15911) ingress: 25.2s 24.2s 24.2s 24.1s 27.2s

Times for minikube (PR 15911) start: 50.2s 49.4s 51.4s 53.7s 54.2s
Times for minikube start: 50.5s 52.1s 53.2s 51.9s 54.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15911) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 26.3s               |
| enable ingress | 32.7s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 26.4s 25.9s 26.7s 26.6s 26.3s
Times for minikube (PR 15911) start: 25.9s 26.5s 25.3s 26.9s 26.9s

Times for minikube ingress: 49.6s 50.6s 20.0s 23.1s 20.1s
Times for minikube (PR 15911) ingress: 23.1s 20.1s 19.1s 23.1s 19.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15911) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.5s               |
| enable ingress | 51.5s    | 39.7s               |
+----------------+----------+---------------------+

Times for minikube start: 20.9s 22.3s 21.4s 21.5s 22.2s
Times for minikube (PR 15911) start: 21.2s 22.4s 21.2s 21.2s 21.6s

Times for minikube ingress: 82.1s 32.5s 78.6s 32.6s 31.6s
Times for minikube (PR 15911) ingress: 32.6s 32.6s 21.6s 80.1s 31.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 1.15 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 2.30 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 46.24 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 46.24 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 47.27 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 47.27 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 70.97 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 83.87 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 96.77 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 96.77 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 99.39 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit f2683ed into kubernetes:master Feb 23, 2023
@spowelljr spowelljr deleted the fixMinikubeServiceList branch February 23, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants